Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(menu): Remove Children API examples #111

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Aug 20, 2018

Menu

Removes all Children API examples for Menu component as these are currently unsupported and broken.

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          39       39           
  Lines         667      667           
  Branches      102      102           
=======================================
  Hits          574      574           
  Misses         90       90           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321d5f7...957cef7. Read the comment docs.

Copy link
Contributor

@alinais alinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync with the team and @levithomason to decide whether we'd like to remove the children handling at all for Menu component.
Meantime, this PR looks good to me.

Copy link
Contributor

@kuzhelov kuzhelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, just add changes to CHANGELOG and we can merge 👍

@miroslavstastny miroslavstastny merged commit 565fc8f into master Aug 20, 2018
@miroslavstastny miroslavstastny deleted the feat/menu-remove-children-api-examples branch August 20, 2018 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants