Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix: remove inferior <-> index circular dependencies #1148

Merged
merged 6 commits into from
Apr 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- `chatBehavior` - remove role 'presentation' @sophieH29 ([#1137](https://github.com/stardust-ui/react/pull/1137))
- Temporarily remove static type references in `slotClassNames` to prevent circular dependency crashes @kuzhelov ([#1145](https://github.com/stardust-ui/react/pull/1145))
- Fix `EventListener` to not rerender on `listener` prop change @layershifter ([#1132](https://github.com/stardust-ui/react/pull/1132))
- Fix circular dependencies from inferior modules to `index` files @kuzhelov ([#1148](https://github.com/stardust-ui/react/pull/1148))

### Features
- Add predefined icon set for the usages in the `Input`, `Dropdown` and `AccordionTitle` components @mnajdova ([#1120](https://github.com/stardust-ui/react/pull/1120))
Expand Down
3 changes: 3 additions & 0 deletions build/gulp/plugins/util/getComponentInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ const getComponentInfo = (filepath: string) => {
const info: any = components[0]

// add exported Component info
//
// this 'require' instruction might break by producing partially initialized types - because of ts-node module's cache used during processing
// - in that case we might consider to disable ts-node cache when running this command: https://github.com/ReactiveX/rxjs/commit/2f86b9ddccbf020b2e695dd8fe0b79194efa3f56
const Component = require(absPath).default
info.constructorName = _.get(Component, 'prototype.constructor.name', null)

Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/components/Ref/RefFindNode.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import * as PropTypes from 'prop-types'
import * as React from 'react'
import * as ReactDOM from 'react-dom'

import { ChildrenComponentProps, handleRef } from '../../lib'
import { ChildrenComponentProps } from '../../lib/commonPropInterfaces'
import handleRef from '../../lib/handleRef'

export interface RefFindNodeProps extends ChildrenComponentProps<React.ReactElement<any>> {
/**
Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/components/Ref/RefForward.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import * as customPropTypes from '@stardust-ui/react-proptypes'
import * as PropTypes from 'prop-types'
import * as React from 'react'

import { ChildrenComponentProps, handleRef } from '../../lib'
import { ChildrenComponentProps } from '../../lib/commonPropInterfaces'
import handleRef from '../../lib/handleRef'

export interface RefForwardProps extends ChildrenComponentProps<React.ReactElement<any>> {
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/lib/renderComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { mergeComponentStyles, mergeComponentVariables } from './mergeThemes'
import { FocusZoneProps, FocusZone, FocusZone as FabricFocusZone } from './accessibility/FocusZone'
import { FOCUSZONE_WRAP_ATTRIBUTE } from './accessibility/FocusZone/focusUtilities'
import createAnimationStyles from './createAnimationStyles'
import { generateColorScheme } from '.'
import { generateColorScheme } from './colorUtils'

export interface RenderResultConfig<P> {
ElementType: React.ElementType<P>
Expand Down