This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): do not propagate any keyboard events #1180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1156
Issues caused:
Because of
Portal
events propagating to the parent components in React element tree, it caused post-effects: keyboard event was propagated outsidePortal
, and was handled by another component too. (Issue example #1156)Why:
FocusTrapZone
should not only trap focus but totally block user interaction outside of it - i.e. stop propagating keyboard events.