-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
@@ -37,7 +36,7 @@ const ComponentExampleVariables: React.FunctionComponent< | |||
const { onChange, overriddenVariables, usedVariables } = props | |||
|
|||
const { theme } = React.useContext<ProviderContextPrepared>(ThemeContext) | |||
const [hideUnused, setHideUnused] = React.useState(true) | |||
const [hideUnused] = React.useState(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just temporary and we want to invest into finding a way hot to do it or should we remove this completely? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hide this temporary and see what we can do later
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
======================================
Coverage 75.8% 75.8%
======================================
Files 160 160
Lines 5572 5572
Branches 1631 1631
======================================
Hits 4224 4224
Misses 1334 1334
Partials 14 14
Continue to review full report at Codecov.
|
@@ -223,6 +223,7 @@ const renderComponent = <P extends {}>( | |||
const direction = rtl ? 'rtl' : 'ltr' | |||
const felaParam = { | |||
theme: { direction }, | |||
displayName, // does not affect styles, only used by useEnhancedRenderer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayName, // does not affect styles, only used by useEnhancedRenderer | |
displayName, // does not affect styles, only used by useEnhancedRenderer in doc site |
Fixes #1997
Hide unused variables still does not work as it would require to pass unresolved styles and component variables to Fela and we removed that in #1957.
Performance wins over docs => Hide unused variables (temporarily) removed from docs.