This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(components): remove animation
prop from all components
#2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
requested review from
aneeshack4,
mnajdova,
levithomason,
khmakoto and
layershifter
January 14, 2020 19:20
joschect
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron and
miroslavstastny
as code owners
January 14, 2020 19:20
khmakoto
approved these changes
Jan 14, 2020
Perf comparison
Generated by 🚫 dangerJS |
aneeshack4
approved these changes
Jan 14, 2020
layershifter
suggested changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the issue with snapshots before merging
packages/react/test/specs/utils/__snapshots__/felaRenderer-test.tsx.snap
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Jan 15, 2020
mnajdova
approved these changes
Jan 15, 2020
khmakoto
approved these changes
Jan 15, 2020
Is there something that blocks merging? |
@layershifter Given the bug in Animation, I figured I should investigate that first. I've been looking into it. I guess I don't need a fix atm but I think it might be good to have a better idea as to why. That does seem like it might be an unrelated pr though. |
layershifter
changed the title
Styles: Remove animation prop
fix(components): remove Jan 17, 2020
animation
prop from all components
@joschect We had an offline conversation and agreed that we will fix linked issue separately, so there are no blockers for this PR 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
<Animation/>
component with the same animation props passed in.Before
After
Why?
The animation prop added uneeded bulk to the api surface and would only be used in certain situations. Removing it will improve perf slightly, as it was adding another check to every single component render. Additionally a quick search has shown that this prop is not currently used and that the animation component is already favored.