Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Removing all remaining references to stardust. #2242

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

aneeshack4
Copy link
Contributor

Mostly in the specs file, one in a comment in accessibility file.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jan 14, 2020

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.72 0.48 1.5:1 2000 1434
🔧 Button.Fluent 1.51 0.22 6.86:1 1000 1514
🔧 Checkbox.Fluent 1.63 0.31 5.26:1 1000 1626
🔧 Dialog.Fluent 0.4 0.2 2:1 5000 1986
🔧 Dropdown.Fluent 4 0.44 9.09:1 1000 4000
🔧 Icon.Fluent 0.31 0.04 7.75:1 5000 1554
🔧 Image.Fluent 0.12 0.09 1.33:1 5000 584
🔧 Slider.Fluent 2.4 0.36 6.67:1 1000 2395
🦄 Text.Fluent 0.06 0.24 0.25:1 5000 294
🦄 Tooltip.Fluent 0.4 20.24 0.02:1 5000 2013

🔧 Needs work     🎯 On target     🦄 Amazing

Generated by 🚫 dangerJS

specs/Icon.md Outdated Show resolved Hide resolved
specs/Button.md Outdated Show resolved Hide resolved
specs/Menu.md Outdated Show resolved Hide resolved
Copy link
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix

@aneeshack4 aneeshack4 requested a review from dzearing January 15, 2020 20:59
Copy link
Member

@khmakoto khmakoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nits.

specs/Checkbox.md Outdated Show resolved Hide resolved
specs/Checkbox.md Outdated Show resolved Hide resolved
specs/Icon.md Outdated Show resolved Hide resolved
specs/Link.md Outdated Show resolved Hide resolved
specs/Link.md Outdated Show resolved Hide resolved
specs/Menu.md Outdated Show resolved Hide resolved
specs/Slider.md Outdated Show resolved Hide resolved
specs/Link.md Outdated Show resolved Hide resolved
Co-Authored-By: Makoto Morimoto <humbertomakotomorimoto@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants