This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusTrapZone): Port FocusTrapZone leak fix from Fabric #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
added 2 commits
January 24, 2020 15:29
Perf comparison
Generated by 🚫 dangerJS |
miroslavstastny
approved these changes
Jan 24, 2020
miroslavstastny
pushed a commit
that referenced
this pull request
Jan 30, 2020
port FocusTrapZone leak fix from Fabric (cherry picked from commit 9f69c93)
miroslavstastny
pushed a commit
that referenced
this pull request
Jan 31, 2020
port FocusTrapZone leak fix from Fabric (cherry picked from commit 9f69c93)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FocusTrapZone was keeping reference to previously focused elements. This PR cleans up that reference when unmounted.
https://github.com/OfficeDev/office-ui-fabric-react/pull/11618/files