This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(typings): enable strict mode for projects #2323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 5, 2020 14:23
…m/stardust-ui/react into fix/projects-tests
miroslavstastny
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
layershifter
changed the title
fix(typings): enable strict mode for projects [WIP]
fix(typings): enable strict mode for projects
Feb 6, 2020
kenotron
added a commit
to microsoft/fluentui
that referenced
this pull request
Feb 26, 2020
* fix(typings): enable strict mode for projects (microsoft/fluent-ui-react#2323) * chore(build): Add sourcemaps to commonjs and es packages (microsoft/fluent-ui-react#2329) * fix(SSR): fix document usage and add project test (microsoft/fluent-ui-react#2330) * fix(Toolbar): focus first item each time a focused element is hidden (microsoft/fluent-ui-react#2321) * updating yarn.lock Co-authored-by: Kenneth Chau <kenotron@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2259.
This PR:
strict
mode for our TypeScript test to catch other possible issues and our compatibility withstrict
mode