Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(typings): enable strict mode for projects #2323

Merged
merged 4 commits into from
Feb 6, 2020
Merged

fix(typings): enable strict mode for projects #2323

merged 4 commits into from
Feb 6, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Feb 5, 2020 •
edited
Loading

Fixes #2259.

This PR:

  • enforces strict mode for our TypeScript test to catch other possible issues and our compatibility with strict mode
  • fixes types to avoid dependency on Lodash in result typings

@layershifter layershifter mentioned this pull request Feb 5, 2020
Closed
@layershifter layershifter added 🗑️ chore 🧰 fix Introduces fix for broken behavior. labels Feb 6, 2020
miroslavstastny
miroslavstastny approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 6, 2020 •
edited
Loading

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.55 0.45 1.22:1 2000 1097
🔧 Button.Fluent 1.2 0.17 7.06:1 1000 1201
🔧 Checkbox.Fluent 1.35 0.29 4.66:1 1000 1350
🔧 Dialog.Fluent 0.42 0.21 2:1 5000 2114
🔧 Dropdown.Fluent 5.17 0.43 12.02:1 1000 5166
🔧 Icon.Fluent 0.33 0.04 8.25:1 5000 1656
🔧 Image.Fluent 0.15 0.1 1.5:1 5000 754
🔧 Slider.Fluent 2.54 0.41 6.2:1 1000 2540
🔧 Text.Fluent 0.06 0.02 3:1 5000 276
🦄 Tooltip.Fluent 0.42 20.14 0.02:1 5000 2102

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 293 244 1.2:1
TreeMinimalPerf.default 982 856 1.15:1
ItemLayoutMinimalPerf.default 2001 1766 1.13:1
MenuMinimalPerf.default 2039 1826 1.12:1
Dropdown.Fluent 5166 4683 1.1:1
ImageMinimalPerf.default 594 547 1.09:1
Image.Fluent 754 701 1.08:1
Text.Fluent 276 256 1.08:1
FlexMinimalPerf.default 387 363 1.07:1
AnimationMinimalPerf.default 463 437 1.06:1
GridMinimalPerf.default 1043 983 1.06:1
IconMinimalPerf.default 1304 1225 1.06:1
ProviderMergeThemesPerf.default 1110 1054 1.05:1
CustomToolbarPrototype.default 3823 3646 1.05:1
ButtonMinimalPerf.default 1209 1162 1.04:1
DropdownMinimalPerf.default 4055 3913 1.04:1
ReactionMinimalPerf.default 2867 2757 1.04:1
PortalMinimalPerf.default 236 229 1.03:1
RefMinimalPerf.default 154 150 1.03:1
Icon.Fluent 1656 1613 1.03:1
AlertMinimalPerf.default 527 515 1.02:1
LabelMinimalPerf.default 1818 1784 1.02:1
ListMinimalPerf.default 757 740 1.02:1
LoaderMinimalPerf.default 2491 2441 1.02:1
TableMinimalPerf.default 586 576 1.02:1
Slider.Fluent 2540 2501 1.02:1
ChatDuplicateMessagesPerf.default 521 515 1.01:1
LayoutMinimalPerf.default 546 539 1.01:1
SegmentMinimalPerf.default 1301 1291 1.01:1
TextAreaMinimalPerf.default 2920 2886 1.01:1
BoxMinimalPerf.default 259 258 1:1
PopupMinimalPerf.default 329 329 1:1
StatusMinimalPerf.default 861 865 1:1
VideoMinimalPerf.default 651 651 1:1
AttachmentSlotsPerf.default 3147 3184 0.99:1
ButtonSlotsPerf.default 1658 1672 0.99:1
ListCommonPerf.default 1117 1128 0.99:1
ProviderMinimalPerf.default 598 603 0.99:1
ChatMinimalPerf.default 1568 1607 0.98:1
DialogMinimalPerf.default 1679 1705 0.98:1
HeaderMinimalPerf.default 494 505 0.98:1
MenuButtonMinimalPerf.default 1402 1424 0.98:1
SliderMinimalPerf.default 1998 2041 0.98:1
DropdownManyItemsPerf.default 476 489 0.97:1
EmbedMinimalPerf.default 6671 6906 0.97:1
SplitButtonMinimalPerf.default 11798 12104 0.97:1
TooltipMinimalPerf.default 2184 2260 0.97:1
ChatWithPopoverPerf.default 551 574 0.96:1
CheckboxMinimalPerf.default 7135 7434 0.96:1
ToolbarMinimalPerf.default 675 700 0.96:1
AccordionMinimalPerf.default 187 197 0.95:1
CarouselMinimalPerf.default 1775 1871 0.95:1
Dialog.Fluent 2114 2237 0.95:1
HeaderSlotsPerf.default 1478 1573 0.94:1
Avatar.Fluent 1097 1172 0.94:1
AttachmentMinimalPerf.default 923 992 0.93:1
RadioGroupMinimalPerf.default 400 435 0.92:1
DividerMinimalPerf.default 875 966 0.91:1
InputMinimalPerf.default 889 988 0.9:1
HierarchicalTreeMinimalPerf.default 861 983 0.88:1
Tooltip.Fluent 2102 2382 0.88:1
Button.Fluent 1201 1409 0.85:1
AvatarMinimalPerf.default 571 707 0.81:1
Checkbox.Fluent 1350 1659 0.81:1
FormMinimalPerf.default 791 1078 0.73:1

Generated by 🚫 dangerJS

@layershifter layershifter changed the title fix(typings): enable strict mode for projects [WIP] fix(typings): enable strict mode for projects Feb 6, 2020
@layershifter layershifter merged commit c848bd4 into master Feb 6, 2020
@layershifter layershifter deleted the fix/projects-tests branch February 6, 2020 14:05
kenotron added a commit to microsoft/fluentui that referenced this pull request Feb 26, 2020
@miroslavstastny @kenotron
Chore/adopt latest build (#12057)
d35bcb2 
* fix(typings): enable strict mode for projects (microsoft/fluent-ui-react#2323)

* chore(build): Add sourcemaps to commonjs and es packages (microsoft/fluent-ui-react#2329)

* fix(SSR): fix document usage and add project test (microsoft/fluent-ui-react#2330)

* fix(Toolbar): focus first item each time a focused element is hidden (microsoft/fluent-ui-react#2321)

* updating yarn.lock

Co-authored-by: Kenneth Chau <kenotron@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miroslavstastny miroslavstastny miroslavstastny approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing dzearing is a code owner

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345 ecraig12345 is a code owner

@JasonGore JasonGore Awaiting requested review from JasonGore JasonGore is a code owner

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@kenotron kenotron Awaiting requested review from kenotron kenotron is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
🗑️ chore 🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Milestone
No milestone
3 participants
@layershifter @DustyTheBot @miroslavstastny