Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Pompomon/table prototypes #2379

Merged
merged 5 commits into from
Feb 25, 2020
Merged

Pompomon/table prototypes #2379

merged 5 commits into from
Feb 25, 2020

Conversation

pompomon
Copy link
Contributor

Adding prototype for popover in Table header

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 21, 2020

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.46 0.37 1.24:1 2000 919
🦄 Button.Fluent 0.11 0.19 0.58:1 1000 113
🔧 Checkbox.Fluent 0.75 0.28 2.68:1 1000 745
🔧 Dialog.Fluent 0.32 0.17 1.88:1 5000 1577
🔧 Dropdown.Fluent 3.31 0.36 9.19:1 1000 3313
🔧 Icon.Fluent 0.12 0.03 4:1 5000 602
🦄 Image.Fluent 0.04 0.07 0.57:1 5000 224
🔧 Slider.Fluent 1.37 0.29 4.72:1 1000 1365
🔧 Text.Fluent 0.06 0.02 3:1 5000 276
🦄 Tooltip.Fluent 0.11 16.9 0.01:1 5000 562

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 171 143 1.2:1
ProviderMinimalPerf.default 626 532 1.18:1
DropdownMinimalPerf.default 3779 3301 1.14:1
ImageMinimalPerf.default 265 232 1.14:1
HierarchicalTreeMinimalPerf.default 1045 928 1.13:1
ListNestedPerf.default 746 659 1.13:1
TextAreaMinimalPerf.default 3049 2747 1.11:1
ChatMinimalPerf.default 458 423 1.08:1
TextMinimalPerf.default 270 251 1.08:1
Tooltip.Fluent 562 522 1.08:1
IconMinimalPerf.default 345 322 1.07:1
ListCommonPerf.default 914 851 1.07:1
DialogMinimalPerf.default 1623 1537 1.06:1
ProviderMergeThemesPerf.default 1219 1154 1.06:1
TableMinimalPerf.default 587 552 1.06:1
ReactionMinimalPerf.default 2377 2268 1.05:1
TreeMinimalPerf.default 888 845 1.05:1
AnimationMinimalPerf.default 519 498 1.04:1
InputMinimalPerf.default 964 926 1.04:1
TooltipMinimalPerf.default 659 635 1.04:1
VideoMinimalPerf.default 699 672 1.04:1
AvatarMinimalPerf.default 513 499 1.03:1
ButtonMinimalPerf.default 133 129 1.03:1
LabelMinimalPerf.default 856 833 1.03:1
CustomToolbarPrototype.default 3601 3500 1.03:1
Dropdown.Fluent 3313 3231 1.03:1
Icon.Fluent 602 587 1.03:1
MenuMinimalPerf.default 1879 1846 1.02:1
SliderMinimalPerf.default 1376 1343 1.02:1
StatusMinimalPerf.default 244 239 1.02:1
Checkbox.Fluent 745 731 1.02:1
Dialog.Fluent 1577 1542 1.02:1
AttachmentMinimalPerf.default 874 869 1.01:1
EmbedMinimalPerf.default 5927 5891 1.01:1
HeaderSlotsPerf.default 1781 1756 1.01:1
LoaderMinimalPerf.default 826 818 1.01:1
PortalMinimalPerf.default 229 227 1.01:1
TreeWith60ListItems.default 226 224 1.01:1
BoxMinimalPerf.default 242 241 1:1
ChatWithPopoverPerf.default 509 507 1:1
ItemLayoutMinimalPerf.default 1627 1620 1:1
MenuButtonMinimalPerf.default 1436 1434 1:1
Button.Fluent 113 113 1:1
CheckboxMinimalPerf.default 3621 3663 0.99:1
SegmentMinimalPerf.default 1112 1124 0.99:1
SplitButtonMinimalPerf.default 10955 11093 0.99:1
Slider.Fluent 1365 1382 0.99:1
Text.Fluent 276 279 0.99:1
DropdownManyItemsPerf.default 462 471 0.98:1
RadioGroupMinimalPerf.default 399 406 0.98:1
ToolbarMinimalPerf.default 787 804 0.98:1
Avatar.Fluent 919 938 0.98:1
CarouselMinimalPerf.default 1931 1996 0.97:1
HeaderMinimalPerf.default 530 546 0.97:1
Image.Fluent 224 230 0.97:1
AttachmentSlotsPerf.default 3085 3206 0.96:1
LayoutMinimalPerf.default 536 559 0.96:1
ListWith60ListItems.default 138 144 0.96:1
PopupMinimalPerf.default 306 320 0.96:1
FlexMinimalPerf.default 354 371 0.95:1
ListMinimalPerf.default 322 339 0.95:1
AccordionMinimalPerf.default 179 191 0.94:1
GridMinimalPerf.default 981 1043 0.94:1
ButtonSlotsPerf.default 594 636 0.93:1
AlertMinimalPerf.default 530 574 0.92:1
DividerMinimalPerf.default 887 963 0.92:1
ChatDuplicateMessagesPerf.default 368 403 0.91:1
FormMinimalPerf.default 758 903 0.84:1

Generated by 🚫 dangerJS

@pompomon pompomon merged commit 22af6f9 into master Feb 25, 2020
@pompomon pompomon deleted the pompomon/table-prototypes branch February 25, 2020 09:56
</Table.Row>
<Table.Row key="3" accessibility={gridRowBehavior}>
<Table.Cell content="3" key="1-1" accessibility={gridCellBehavior} />
<Table.Cell content="Ali" key="1-2" accessibility={gridCellBehavior} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key are redundant there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants