Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Hide Safari default input outline #2381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sheff146
Copy link

@sheff146 sheff146 commented Feb 21, 2020

Fixes issue #2376 where ugly default outline appeared on focused input in Safari.
Before:
safari
After:
Screenshot 2020-02-21 at 16 44 52

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.44 0.39 1.13:1 2000 878
🦄 Button.Fluent 0.1 0.18 0.56:1 1000 103
🔧 Checkbox.Fluent 0.73 0.3 2.43:1 1000 727
🔧 Dialog.Fluent 0.3 0.16 1.88:1 5000 1491
🔧 Dropdown.Fluent 3.06 0.38 8.05:1 1000 3055
🔧 Icon.Fluent 0.12 0.03 4:1 5000 600
🦄 Image.Fluent 0.05 0.08 0.63:1 5000 231
🔧 Slider.Fluent 1.35 0.29 4.66:1 1000 1347
🔧 Text.Fluent 0.05 0.02 2.5:1 5000 259
🦄 Tooltip.Fluent 0.11 18.15 0.01:1 5000 555

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 910 683 1.33:1
FlexMinimalPerf.default 503 396 1.27:1
Tooltip.Fluent 555 450 1.23:1
ChatMinimalPerf.default 486 409 1.19:1
AnimationMinimalPerf.default 535 459 1.17:1
ProviderMinimalPerf.default 680 587 1.16:1
LabelMinimalPerf.default 892 790 1.13:1
ReactionMinimalPerf.default 2592 2344 1.11:1
StatusMinimalPerf.default 249 225 1.11:1
ListMinimalPerf.default 322 294 1.1:1
ButtonSlotsPerf.default 608 561 1.08:1
SplitButtonMinimalPerf.default 12369 11500 1.08:1
Image.Fluent 231 214 1.08:1
AvatarMinimalPerf.default 504 471 1.07:1
HeaderMinimalPerf.default 455 426 1.07:1
GridMinimalPerf.default 853 803 1.06:1
PopupMinimalPerf.default 353 333 1.06:1
PortalMinimalPerf.default 232 219 1.06:1
SliderMinimalPerf.default 1392 1312 1.06:1
HierarchicalTreeMinimalPerf.default 797 757 1.05:1
ListCommonPerf.default 920 877 1.05:1
TableMinimalPerf.default 561 535 1.05:1
Icon.Fluent 600 569 1.05:1
HeaderSlotsPerf.default 1262 1212 1.04:1
TreeWith60ListItems.default 220 212 1.04:1
EmbedMinimalPerf.default 5909 5747 1.03:1
Slider.Fluent 1347 1312 1.03:1
Text.Fluent 259 252 1.03:1
DialogMinimalPerf.default 1561 1527 1.02:1
InputMinimalPerf.default 913 897 1.02:1
MenuButtonMinimalPerf.default 1456 1423 1.02:1
TooltipMinimalPerf.default 688 674 1.02:1
ImageMinimalPerf.default 234 232 1.01:1
ListWith60ListItems.default 152 151 1.01:1
SegmentMinimalPerf.default 1141 1126 1.01:1
DividerMinimalPerf.default 847 846 1:1
ItemLayoutMinimalPerf.default 1654 1652 1:1
MenuMinimalPerf.default 1861 1857 1:1
CustomToolbarPrototype.default 3358 3359 1:1
ToolbarMinimalPerf.default 786 783 1:1
AttachmentMinimalPerf.default 821 827 0.99:1
AttachmentSlotsPerf.default 3020 3044 0.99:1
TextAreaMinimalPerf.default 2831 2859 0.99:1
Checkbox.Fluent 727 736 0.99:1
Dialog.Fluent 1491 1504 0.99:1
ChatWithPopoverPerf.default 509 520 0.98:1
CheckboxMinimalPerf.default 3454 3518 0.98:1
RefMinimalPerf.default 149 152 0.98:1
TextMinimalPerf.default 264 270 0.98:1
TreeMinimalPerf.default 813 831 0.98:1
VideoMinimalPerf.default 655 666 0.98:1
Avatar.Fluent 878 896 0.98:1
BoxMinimalPerf.default 233 239 0.97:1
DropdownMinimalPerf.default 3258 3349 0.97:1
IconMinimalPerf.default 292 300 0.97:1
LoaderMinimalPerf.default 763 786 0.97:1
AccordionMinimalPerf.default 209 217 0.96:1
ChatDuplicateMessagesPerf.default 371 387 0.96:1
LayoutMinimalPerf.default 604 628 0.96:1
ProviderMergeThemesPerf.default 1072 1118 0.96:1
Dropdown.Fluent 3055 3178 0.96:1
ListNestedPerf.default 645 687 0.94:1
DropdownManyItemsPerf.default 412 442 0.93:1
RadioGroupMinimalPerf.default 407 438 0.93:1
ButtonMinimalPerf.default 119 130 0.92:1
CarouselMinimalPerf.default 1815 1993 0.91:1
Button.Fluent 103 113 0.91:1
AlertMinimalPerf.default 625 700 0.89:1

Generated by 🚫 dangerJS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants