Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(debug): make debug a runtime dependency #318

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

dvdzkwsk
Copy link
Contributor

@dvdzkwsk dvdzkwsk commented Oct 5, 2018

Fixes #301. Ideally we could get rid of this dependency if in production environments, but this seems to be a fine solution in the meantime.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          62       62           
  Lines        1176     1176           
  Branches      152      175   +23     
=======================================
  Hits         1053     1053           
  Misses        121      121           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe12bf...b59952d. Read the comment docs.

@levithomason
Copy link
Member

Yep, in SUIR we strip debug statements in the prod build. This is part of the reason we'll integrate babel back into Stardust soon.

@levithomason levithomason merged commit 753b2be into master Oct 5, 2018
@levithomason levithomason deleted the fix/debug-dependency branch October 5, 2018 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants