This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore: add yarn engines entry #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
chore/add-yarn-engines-entry
branch
from
af9726a
to
9c259cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 41 41
Lines 1337 1337
Branches 168 168
=======================================
Hits 1228 1228
Misses 105 105
Partials 4 4Continue to review full report at Codecov.
|
layershifter
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Looks correct to me:
https://yarnpkg.com/lang/en/docs/package-json/#toc-engines
You can see an example issue in #411:
mnajdova
approved these changes
Nov 6, 2018
kuzhelov
approved these changes
Nov 7, 2018
bmdalex
force-pushed
the
chore/add-yarn-engines-entry
branch
from
9c259cb
to
a950fcf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.json engines entry for yarn (chore)
Motivation
yarn
1.10.0introduces an integrity field with sha512 authentication to yarn.lock to preserve the integrity of every installed package before its code is executed.A machine with a version of
yarnlower than1.10.0would automatically remove theentries from
yarn.lockcausing unwanted changes.Resolution
This PR that forces devs to upgrade to
yarn 1.10.0or above by adding theenginesentry topackage.json.Note: On Mac, the most reliable way to upgrade
yarnto latest stable version is: