Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

docs(ChatPane): Add attachments and link to chat pane messages in prototype #514

Merged
merged 10 commits into from
Nov 26, 2018

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Nov 22, 2018

This PR aims to improve chat pane behavior by adding Attachments and links to chat message so provide the proper accessibility experience for it.

  1. Navigate with UP / DOWN arrow keys between messages
  2. Click Enter on focused message
  3. The link will get focus first
  4. Press Tab
  5. First attachment will get focus
  6. Press Tab
  7. Action button on the attachment will get focus
  8. Press Enter
  9. Popup will open with context menu and trap the focus
  10. Press Esc
  11. Focus goes to action trigger
  12. Press Tab and go to the next attachment OR press Esc and focus message again, so you'll be able to navigate between messages with UP/DOWN arrow keys

image

Opened context menu:
image

@sophieH29 sophieH29 self-assigned this Nov 22, 2018
@sophieH29 sophieH29 changed the title docs(ChatPane):Add attachments and link to chat pane messages in prototype docs(ChatPane): Add attachments and link to chat pane messages in prototype Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #514 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files          42       42           
  Lines        1455     1455           
  Branches      212      212           
=======================================
  Hits         1283     1283           
  Misses        167      167           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33711e...28501f0. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small note, LGTM

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good, have tested it locally and it is behaving as in the description. However, it is a bit overwhelming for all messages to have attachments. Can you at least add the attachments on every 5th message let's say? Will approve after this change. No other changes required from my side.

@sophieH29 sophieH29 merged commit fc92d68 into master Nov 26, 2018
@sophieH29 sophieH29 deleted the docs/chat-pane-attachments-prototype branch November 26, 2018 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants