This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
chore(package): update Fela to latest #768
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3ffab7f
wip
layershifter a8ad56f
more wip!
layershifter 2d24298
fix table
layershifter 2e1d386
restore changes
layershifter 51b7b7c
remove if
layershifter 5087e4e
cleanup, update fela
layershifter 4dc114d
update `react-fela`
layershifter f6d43db
add entry
layershifter c6c2af9
Merge branches 'chore/update-fela' and 'master' of https://github.com…
layershifter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import * as webpack from 'webpack' | |
import config from '../config' | ||
|
||
const { paths } = config | ||
const { __DEV__, __PERF__, __PROD__ } = config.compiler_globals | ||
const { __DEV__, __PROD__ } = config.compiler_globals | ||
|
||
const webpackConfig: any = { | ||
name: 'client', | ||
|
@@ -37,9 +37,7 @@ const webpackConfig: any = { | |
exclude: /node_modules/, | ||
options: { | ||
useCache: true, | ||
configFileName: __PERF__ | ||
? paths.base('build/tsconfig.perf.json') | ||
: paths.base('build/tsconfig.docs.json'), | ||
configFileName: paths.base('build/tsconfig.perf.json'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This config is used only for perf stuff, cruft |
||
errorsAsWarnings: __DEV__, | ||
}, | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,9 @@ export interface ProviderConsumerProps { | |
/** | ||
* The Provider's Consumer is for accessing theme. | ||
*/ | ||
const ProviderConsumer: React.SFC<ProviderConsumerProps> = props => <FelaTheme {...props} /> | ||
const ProviderConsumer: React.SFC<ProviderConsumerProps> = ({ render }) => ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We had prev here spreading all props, not just the render, not sure if there were other props here, but it may be worth taking a look... |
||
<FelaTheme>{render}</FelaTheme> | ||
) | ||
|
||
ProviderConsumer.propTypes = { | ||
render: PropTypes.func.isRequired, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍