[ListItem] make modifier inputs optional #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
When using the ListItem modifiers for line limit, it is extending the modifier provided by swiftui which sets the value defaulted to nil. By having the value be nil, the ListItem will grow in number of lines to show all the content provided for title/subtitle/footer.
When using these modifiers though, we have to optionally add them potentially. To support a ListItem providing a line limit for title / subtitle / footer optionally, we have to be allowed to pass in an optional value.
Binary change
N/A
Verification
It builds with the input values allowed to be optional. In the Demo app also set the values explicitly to nil and to a value. Saw the UI respected the values.
Microsoft Reviewers: Open in CodeFlow