Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move iOS projects to always use spaces for indentation #1998

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Apr 17, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

We always want spaces for indentation in our iOS projects--let's enforce that at an Xcode project level. Useful for people (like me!) who move between tabs-only and spaces-only projects.

Binary change

n/a -- no impact on build

Verification

Verified that Xcode uses spaces in both the library and demo app projects, even when the global app settings are set to tabs.

Visual Verification

n/a

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner April 17, 2024 21:33
Copy link
Contributor

@laminesm laminesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these rules be mirrored for fluent Mac as well?

@mischreiber
Copy link
Contributor Author

Should these rules be mirrored for fluent Mac as well?

Turns out that the vast majority of Fluent Mac code still uses tabs, rather than spaces. We'll have to think about what to do there before making any commitments.

@mischreiber mischreiber merged commit badfa8e into microsoft:main Apr 18, 2024
7 checks passed
@mischreiber mischreiber deleted the spacesInProject branch April 18, 2024 04:45
@joannaquu joannaquu mentioned this pull request May 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants