Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a convenience init for FluentListSection #2024

Merged
merged 3 commits into from
May 17, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented May 17, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Adding a convenience initializer for FluentListSection where SectionHeaderContent == Text, SectionFooterContent == EmptyView.

// MARK: - Before

FluentListSection {
    // ...
} header {
    Text("Hello!")
}

// MARK: - After

FluentListSection("Hello!") {
    // ...
}

Binary change

Total increase: 6,576 bytes
Total decrease: -8 bytes

File Before After Delta
Total 31,212,536 bytes 31,219,104 bytes ⚠️ 6,568 bytes
Full breakdown
File Before After Delta
FluentListSection.o 38,992 bytes 44,392 bytes ⚠️ 5,400 bytes
__.SYMDEF 4,865,344 bytes 4,866,520 bytes ⚠️ 1,176 bytes
FluentListSectionHeader.o 47,632 bytes 47,624 bytes 🎉 -8 bytes

Verification

No changes to FluentListSection uses.

Visual Verification
ListItem ListActionItem
ListItem ListActionItem

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner May 17, 2024 16:52
@mischreiber mischreiber enabled auto-merge (squash) May 17, 2024 22:32
@mischreiber mischreiber merged commit 39c1e32 into microsoft:main May 17, 2024
7 checks passed
@mischreiber mischreiber deleted the FluentListSectionTitle branch May 22, 2024 13:54
@joannaquu joannaquu mentioned this pull request May 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants