[TableViewCell] fix height calculation based on font size

[alexanderboswell]

Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

When calculating the height of a table view cell, we are incorrectly accounting for which subtitle font to use. This means we are calculating using a font that is bigger than what is expected, meaning our table view cell is rendered larger than needed.

The fix is to ensure we only use the 3 line font if we have 3 lines, otherwise default back to the two line font, which is also the font for one line.

Binary change

N/A

Verification

Before rendered height: 66, calculated height: 64	After rendered height: 64, calculated height: 64

saw the height of each cell in the view debugger and compared the value. All of these scenarios it was still as expected

regular text size

scenario	Before	After
single line cell 48 height
double line cell 64 height
triple line cell 84 height
cell without custom view 64 height
cell with custom accessory view 48 height
cell with text truncation 84 height
cell with text wrapping 84 height

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

[joannaquu]

should be one more case in line 1570

[alexanderboswell]

should be one more case in line 1570

Actually, that scenario is wrapped in

if layoutType == .twoLines || layoutType == .threeLines {
}

so there is no scenario in which we could hit that line and it be the .oneLine scenario