-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate Bottom Commanding header height instead of using constant #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mischreiber
approved these changes
Jun 6, 2024
lukas-cap
approved these changes
Jun 6, 2024
ios/FluentUI/Bottom Commanding/BottomCommandingController.swift
Outdated
Show resolved
Hide resolved
cbowdoin
approved these changes
Jun 6, 2024
nodes11
approved these changes
Jun 6, 2024
3 tasks
lukas-cap
pushed a commit
to lukas-cap/fluentui-apple
that referenced
this pull request
Jul 17, 2024
…nstant (microsoft#2041)" This reverts commit d298dac.
joannaquu
added a commit
to joannaquu/fluentui-apple
that referenced
this pull request
Jul 17, 2024
…nstant (microsoft#2041)" This reverts commit d298dac.
joannaquu
added a commit
to joannaquu/fluentui-apple
that referenced
this pull request
Jul 17, 2024
…nstant (microsoft#2041)" This reverts commit d298dac.
12 tasks
joannaquu
added a commit
to joannaquu/fluentui-apple
that referenced
this pull request
Jul 26, 2024
…nstant (microsoft#2041)" This reverts commit d298dac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Currently,
BottomCommandingController
'sheaderContentHeight
is hard-coded in as a constant of 66. When the hero item's titles are one line, this is ok. However when it is multi-lined, there is not enough bottom padding. Update it so thatheaderContentHeight
is calculated usingsystemLayoutSizeFitting
.Binary change
Total increase: 6,072 bytes
Total decrease: 0 bytes
Full breakdown
Verification
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow