Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various a11y fixes for SearchBar and BadgeView (#2054) #2067

Merged

Conversation

KeithA45
Copy link

@KeithA45 KeithA45 commented Jul 16, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Cherry-picked recent accessibility fixes for upcoming minor release update.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@KeithA45 KeithA45 requested a review from a team as a code owner July 16, 2024 18:46
@KeithA45 KeithA45 closed this Jul 16, 2024
@KeithA45 KeithA45 reopened this Jul 16, 2024
@KeithA45
Copy link
Author

Apologies, accidentally closed and re-opened this PR. This is ready to complete ASAP

@mischreiber mischreiber merged commit fc86b59 into microsoft:main_0.29 Jul 17, 2024
13 checks passed
@KeithA45 KeithA45 deleted the keitha45/cherryPickA11yFixes branch July 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants