Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor and index path of ObjC popup demo #2078

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Jul 29, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The Objective-C demo for PopupMenu wasn't anchoring its popup correctly. Without this change, the popup won't appear due to constraint conflicts. No idea how long this has been broken, but let's fix it.

While here, I'm also updating the starting selection index path to match the Swift demo.

Binary change

n/a - demo only change

Verification

iPad iPhone
PopupDemo-iPad PopupDemo-iPhone

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner July 29, 2024 17:05
@mischreiber mischreiber merged commit 6360f50 into microsoft:main Jul 29, 2024
7 checks passed
@mischreiber mischreiber deleted the fixObjCPopupMenu branch July 29, 2024 19:36
@harrieshin harrieshin mentioned this pull request Aug 16, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants