Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly deprecate UITextItemInteraction for iOS 17 #2086

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Aug 30, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Our public API on iOS includes UITextItemInteraction, which is deprecated in iOS 17. This PR marks it as deprecated as well, and provides an alternate implementation using Apple's recommended replacement.

Bonus: we now support this API on visionOS too! 🥳

Binary change

Total increase: 13,040 bytes
Total decrease: 0 bytes

File Before After Delta
Total 31,325,696 bytes 31,338,736 bytes ⚠️ 13,040 bytes
Full breakdown
File Before After Delta
TableViewHeaderFooterView.o 299,672 bytes 309,216 bytes ⚠️ 9,544 bytes
__.SYMDEF 4,872,728 bytes 4,875,448 bytes ⚠️ 2,720 bytes
FocusRingView.o 848,736 bytes 849,512 bytes ⚠️ 776 bytes

Verification

Tested that both default and custom links work as expected, on both iOS and visionOS.

Visual Verification
iOS visionOS
iOS visionOS

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested a review from a team as a code owner August 30, 2024 21:16
@mischreiber mischreiber requested a review from joannaquu August 30, 2024 21:17
@mischreiber mischreiber enabled auto-merge (squash) September 1, 2024 04:03
@mischreiber mischreiber merged commit f7b1b2e into microsoft:main Sep 1, 2024
7 checks passed
@mischreiber mischreiber deleted the deprecatedAPIs_iOS17 branch September 1, 2024 05:48
@mischreiber mischreiber mentioned this pull request Oct 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants