[fluentui-apple] Have resizingHandleView overlap content in BottomSheetController #2236
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joannaquu
reviewed
Dec 18, 2025
Sources/FluentUI_iOS/Components/BottomSheet/BottomSheetController.swift
Outdated
Show resolved
Hide resolved
joannaquu
reviewed
Dec 18, 2025
Sources/FluentUI_iOS/Components/BottomSheet/BottomSheetController.swift
Outdated
Show resolved
Hide resolved
joannaquu
reviewed
Dec 18, 2025
Sources/FluentUI_iOS/Components/BottomSheet/BottomSheetController.swift
Outdated
Show resolved
Hide resolved
joannaquu
reviewed
Dec 18, 2025
| stackView.bottomAnchor.constraint(equalTo: bottomSheetContentView.bottomAnchor) | ||
| ]) | ||
|
|
||
| if let headerContentView { |
Contributor
There was a problem hiding this comment.
combine with the if let on line 706
Contributor
|
nit: update view hierarchy on line 470 |
joannaquu
reviewed
Dec 18, 2025
| if let headerContentView { | ||
| resizingHandleContentOverlapConstraints = headerContentView.topAnchor.constraint(equalTo: resizingHandleView.bottomAnchor, constant: -currentResizingHandleHeight) | ||
| } else { | ||
| resizingHandleContentOverlapConstraints = expandedContentView.topAnchor.constraint(equalTo: resizingHandleView.bottomAnchor, constant: -currentResizingHandleHeight) |
Contributor
There was a problem hiding this comment.
we'll need to account for new height in expandedSheetHeight/collapsedSheetHeight
veronicasalas
force-pushed
the
user/vsalas/fixingBottomSheetConcentricity
branch
from
0a30dbf to
c1c93b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
In iOS 26, the bottom sheet’s content is designed to align concentrically with the sheet’s rounded corners. However, the presence of the
resizingHandleViewintroduces a visible gap between the content and the corner, breaking this concentric alignment.To address this, the
resizingHandleViewneeds to overlap the bottom sheet’s content, so I’m introducing the new property,shouldResizingViewOverlayContent, which enables this behavior when set to true (the default is false). Additionally, theresizingHandleViewis moved to become a subview ofbottomSheetContentViewWhen this option is enabled, the constant between the
resizingHandleView bottomAnchorand thestackView topAnchoris the resizing handle height so that the resizing handle overlays the content.Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Visual Verification
shouldResizingViewOverlayContentset to falseshouldResizingViewOverlayContentset to truePull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow