Skip to content

[Popover] Add Threshold attributes [v3] #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Jan 26, 2024
Merged

[Popover] Add Threshold attributes [v3] #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6925d8
Add Popover Threshold attributes
dvoituron Jan 25, 2024
38b62a4
Merge branch 'dev' into users/dvoituron/popover-threshold
vnbaaij Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5740,6 +5740,16 @@
Default is unset. See <seealso cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentPopover.HorizontalPosition"/>
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentPopover.VerticalThreshold">
<summary>
How short the space allocated to the default position has to be before the tallest area is selected for layout.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentPopover.HorizontalThreshold">
<summary>
How narrow the space allocated to the default position has to be before the widest area is selected for layout.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentPopover.Open">
<summary>
Gets or sets popover opened state.
Expand Down
4 changes: 2 additions & 2 deletions examples/Demo/Shared/Pages/Popover/Examples/PopoverDefault.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
Open Callout 2
</FluentButton>

<FluentPopover Style="width: 300px;" AnchorId="myPopoverButtonl" @bind-Open="_visibleL">
<FluentPopover Style="width: 300px;" VerticalThreshold="170" AnchorId="myPopoverButtonl" @bind-Open="_visibleL">
<Header>Callout Header</Header>
<Body>
Callout Body
</Body>
<Footer>Callout Footer</Footer>
</FluentPopover>

<FluentPopover Style="width: 300px;" AnchorId="myPopoverButtonr" @bind-Open="_visibleR">
<FluentPopover Style="width: 300px;" VerticalThreshold="170" AnchorId="myPopoverButtonr" @bind-Open="_visibleR">
<Header>Callout Header</Header>
<Body>
Callout Body
Expand Down
2 changes: 2 additions & 0 deletions src/Core/Components/Popover/FluentPopover.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
HorizontalInset="true"
HorizontalDefaultPosition="@HorizontalPosition"
VerticalDefaultPosition="@VerticalPosition.Bottom"
VerticalThreshold="@VerticalThreshold"
HorizontalThreshold="@HorizontalThreshold"
Shadow="@ElevationShadow.Flyout"
Class="@ClassValue"
Style="@StyleValue">
Expand Down
12 changes: 12 additions & 0 deletions src/Core/Components/Popover/FluentPopover.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,18 @@ public partial class FluentPopover : FluentComponentBase
[Parameter]
public HorizontalPosition? HorizontalPosition { get; set; } = AspNetCore.Components.HorizontalPosition.Unset;

/// <summary>
/// How short the space allocated to the default position has to be before the tallest area is selected for layout.
/// </summary>
[Parameter]
public int VerticalThreshold { get; set; } = 0;

/// <summary>
/// How narrow the space allocated to the default position has to be before the widest area is selected for layout.
/// </summary>
[Parameter]
public int HorizontalThreshold { get; set; } = 0;

/// <summary>
/// Gets or sets popover opened state.
/// </summary>
Expand Down