-
Notifications
You must be signed in to change notification settings - Fork 432
[DatePicker] Added OnDoubleClick event and DoubleClickToDate parameter #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed test for OnDoubleClick event.
Hi @dvoituron, |
In addition, is there a better Blazor/C# solution coming up which addresses the current |
I would like to try to find a solution to extend this |
…icrosoft#2567) * [FluentDatePicker] Added OnDoubleClick event and DoubleClickToToday parameter. * [DatePicker] DoubleClickToToday was changed to DoubleClickToDate. Added test for OnDoubleClick event.
Pull Request
📖 Description
OnDoubleClick
event to DatePicker component.DoubleClickToDate
parameter to DatePicker component.DoubleClickToDate
option🎫 Issues
The PR was related to
👩💻 Reviewer Notes
This is the first PR of the 2 separated PRs asked by @dvoituron which implemented the
DoubleClickToDate
feature only.📑 Test Plan
This PR kept the
FluentOverlay
as-is, so it's very difficult to trigger the double-click event on the text field of the date picker, thus difficult to see this feature works. Commenting out theFluentOverlay
temporarily could help a lot during the manual tests.However, the
FluentOverlay
has no side-effect when running the test methodFluentDatePicker_DoubleClickToSetTodayInTextField
, so it runs successfully. I think that's a sample of the cases that automatic tests are not exactly the same as manual tests.✅ Checklist
General
Component-specific
⏭ Next Steps
I'll move the rest "
FluentOverlay
replacement" part of the original PR #2563 to a new PR.