-
Notifications
You must be signed in to change notification settings - Fork 460
[dev-v5] Add FluentAppBar and FluentAppBarItem
#4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m/microsoft/fluentui-blazor into users/vnbaaij/dev-v5/appbar-part1
- Fix test verified files
- Refine show empy logic - Redo & add tests (replace verify with asserts)
- Fix fixed item detection in ts
…nbaaij/dev-v5/appbar-part1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Remove verified files
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds FluentAppBar and FluentAppBarItem components to enable Teams-like app bar functionality in Fluent UI Blazor applications. The implementation includes overflow handling with a popover menu and search capabilities.
Key changes:
- New FluentAppBar component with vertical/horizontal orientation support and overflow management
- New FluentAppBarItem component implementing the IAppBarItem interface
- Enhanced FluentCounterBadge with ShowEmpty parameter to control empty badge visibility
- Documentation restructuring to organize Badge components under a unified Badges section
Reviewed changes
Copilot reviewed 75 out of 90 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/Components/AppBar/FluentAppBar.razor.cs | Core AppBar component logic with overflow and popover handling |
| src/Core/Components/AppBar/FluentAppBarItem.razor.cs | Individual app bar item component implementation |
| src/Core/Components/AppBar/IAppBarItem.cs | Interface defining app bar item contract |
| src/Core/Components/AppBar/InternalAppBarContext.cs | Context for managing app bar item registration |
| src/Core/Components/Badge/FluentCounterBadge.razor.cs | Added ShowEmpty parameter for badge visibility control |
| src/Core/Components/Badge/FluentBadge.razor.cs | Added ContainerStyle parameter for styling flexibility |
| src/Core/Components/Overflow/FluentOverflow.razor.ts | Fixed selector logic for overflow items |
| src/Core/Components/Icons/CoreIcons.cs | Added new icons (Calendar, Clock, Info, MoreHorizontal) |
| tests/Core/Components/AppBar/*.razor | Comprehensive test coverage for AppBar components |
| tests/Core/Components/Badge/FluentCounterBadgeTests.razor | Updated tests to use assertions instead of verified files |
| examples/Demo/**/AppBar/*.razor | Example implementations demonstrating AppBar usage |
| examples/Demo/**/Badges/*.md | Restructured documentation with separate Badge and CounterBadge pages |
| .mcp.json | Configuration file with Playwright MCP extension token |
Comments suppressed due to low confidence (2)
examples/Demo/FluentUI.Demo.Client/Documentation/Components/Badges/BadgesOverview.md:51
- The word "intented" has a spelling error. It should be "intended".
examples/Demo/FluentUI.Demo.Client/Documentation/Components/Badges/CounterBadge/FluentCounterBadge.md:13 - The word "intented" has a spelling error. It should be "intended".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
examples/Demo/FluentUI.Demo.Client/Documentation/Components/AppBar/Examples/AppBarDefault.razor
Outdated
Show resolved
Hide resolved
|
I will review once the other PR has been merged. |
Adds an (adapted) copy of the v4 AppBar and AppBarItem components.
Tests have been added/fixed (they no longer use the verified files)