Merged
Conversation
vnbaaij
changed the title
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to close the AppBar popover when an AppBarItem's OnClick event is invoked. It builds on PR #4421 which enabled OnClick to be invoked for items displayed in the popover menu. The PR also includes changes to demo examples to better demonstrate the overflow/popover behavior.
Changes:
- Modified OnClickHandlerAsync to call TogglePopoverAsync when OnClick is invoked
- Changed TogglePopoverAsync visibility from private to internal to allow access from FluentAppBarItem
- Updated demo examples to use a smaller width to trigger overflow behavior and demonstrate popover functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Core/Components/AppBar/FluentAppBarItem.razor.cs | Added call to TogglePopoverAsync in OnClickHandlerAsync to close popover when item is clicked |
| src/Core/Components/AppBar/FluentAppBar.razor.cs | Changed TogglePopoverAsync from private to internal to allow access from FluentAppBarItem |
| examples/Demo/Shared/Pages/AppBar/Examples/AppBarFromListOfApps.razor | Reduced container width to trigger overflow and changed indentation to tabs |
| examples/Demo/Shared/Pages/AppBar/Examples/AppBarClick.razor | Added container with smaller width to trigger overflow, wrapped AppBar to demonstrate popover, and changed indentation to tabs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
examples/Demo/Shared/Pages/AppBar/Examples/AppBarFromListOfApps.razor
Outdated
Show resolved
Hide resolved
dvoituron
approved these changes
Feb 13, 2026
dvoituron
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #4421 we added the functionality that an
OnClickcan also be invoked if the app bar item is being displayed in the popover menu. This PR adds that invoking theOnClickalso closes the popup.