-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Button] HC fixes button #2679
Merged
Merged
[Button] HC fixes button #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
added
Area: Button
Issues related to the Fluent UI React Native Button component
Area: Accessibility
labels
Mar 3, 2023
Saadnajmi
reviewed
Mar 4, 2023
Saadnajmi
reviewed
Mar 4, 2023
Saadnajmi
approved these changes
Mar 4, 2023
chiuam
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Client reported some issues with the Button in HC.
It looks like we're using colors for plain text on the Button when we should be using ButtonText instead. This works for primary buttons but for other ones we're using the wrong color.
The reason this happens is because the alias tokens don't differentiate between usage in a canvas vs. usage in a button, so most alias tokens point to canvas/text instead of button/button text. Web fixes this by overriding the colors in HC specifically, so we'll do the same. Seems like a failure of the alias token system, but that's a separate conversation.
Changes:
Verification
Pull request checklist
This PR has considered (when applicable):