Convert XML Fluent Icons to ImageVector Compose Icons #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge pull request :O |
android/library/build.gradle
Outdated
| compose = true | ||
| } | ||
| composeOptions { | ||
| kotlinCompilerExtensionVersion = "1.4.3" |
There was a problem hiding this comment.
The Android build check fail as compose compiler & kotlin version is not compatible. As per the
https://developer.android.com/jetpack/androidx/releases/compose-kotlin , compose version 1.2.0-rc02 is compatible with kolin 1.6.21. Please evaluate it.
There was a problem hiding this comment.
Updated the version of compose @mishramayank1, try it again please!
|
+945,851 −13 Wow, with only a little work involved, we've got a huge pull request. |
praveen970
approved these changes
Jan 3, 2024
askNilesh
approved these changes
Jan 29, 2024
|
🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done 🔥
This pull request (PR) aims to enhance the icons set provided by fluent system icons converting existing XML icons to Jetpack Compose ImageVector icons. By migrating to Jetpack Compose, we can leverage the declarative nature of Compose UI and take advantage of its powerful features for rendering scalable icons. This conversion will result in improved performance, flexibility, and maintainability of the icons in the project.
The main purpose was to have fluent API access to Fluent icons, the developer using Jetpack Compose can create an
Iconlike the following:How it was done ✅
I have created a parser that parses the XML icons and converts them to
fluentIconsusingImageVectorcompose's nature usingmaterialPath.Changes Made 💡
Testing Done ✔
I think we can also make some screenshot tests for each icon, but that would take a long time to run the tests.
Missing Stuff 😅
Three icons are still remaining since they don't share the same structure as the other icons (they contain an extra
clip-path); I will try to convert those manually. Here are the icons: