Skip to content

Commit

Permalink
Command bar role (#15614)
Browse files Browse the repository at this point in the history
<!--
!!!!!!! IMPORTANT !!!!!!!

Due to work we're currently doing to prepare master branch for our version 8 beta release,
please hold-off submitting the PR until around October 12 if it's not urgent.
If it is urgent, please submit the PR targeting the 7.0 branch.

This change does not apply to react-northstar contributors.

See #15222 for more details. Sorry for the inconvenience and short notice.
-->

#### Pull request checklist

- [ ] Addresses an existing issue: Fixes #0000
- [x] Include a change request file using `$ yarn change`

#### Description of changes

_Cherry-pick of #15511._

_Original PR description:_

Fix having incorrectly set `role="group"` in between `menubar` and `menuitem`.

#### Focus areas to test

(optional)
  • Loading branch information
khmakoto authored Oct 20, 2020
1 parent 53457a5 commit 07e4870
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 14 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "CommandBar: Fixing incorrect aria role.",
"packageName": "@fluentui/react-internal",
"email": "humbertomakotomorimoto@gmail.com",
"dependentChangeType": "patch",
"date": "2020-10-20T17:32:20.124Z"
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports[`Component Examples renders CommandBar.Basic.Example.tsx correctly 1`] =
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down Expand Up @@ -998,7 +998,7 @@ exports[`Component Examples renders CommandBar.Basic.Example.tsx correctly 1`] =
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`Component Examples renders CommandBar.ButtonAs.Example.tsx correctly 1`
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down Expand Up @@ -1001,7 +1001,7 @@ exports[`Component Examples renders CommandBar.ButtonAs.Example.tsx correctly 1`
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`Component Examples renders CommandBar.CommandBarButtonAs.Example.tsx co
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ exports[`Component Examples renders CommandBar.Lazy.Example.tsx correctly 1`] =
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports[`Component Examples renders CommandBar.SplitDisabled.Example.tsx correct
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ exports[`Component Examples renders DetailsList.Advanced.Example.tsx correctly 1
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down Expand Up @@ -663,7 +663,7 @@ exports[`Component Examples renders DetailsList.Advanced.Example.tsx correctly 1
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ exports[`Component Examples renders Keytips.CommandBar.Example.tsx correctly 1`]
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down Expand Up @@ -436,7 +436,7 @@ exports[`Component Examples renders Keytips.CommandBar.Example.tsx correctly 1`]
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export class CommandBarBase extends React.Component<ICommandBarProps, {}> implem
>
{/*Primary Items*/}
<OverflowSet
role="none"
componentRef={this._overflowSet}
className={css(this._classNames.primarySet)}
items={data.primaryItems}
Expand All @@ -137,6 +138,7 @@ export class CommandBarBase extends React.Component<ICommandBarProps, {}> implem
{/*Secondary Items*/}
{data.farItems && data.farItems.length > 0 && (
<OverflowSet
role="none"
className={css(this._classNames.secondarySet)}
items={data.farItems}
onRenderItem={this._onRenderItem}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports[`CommandBar renders commands correctly 1`] = `
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ exports[`CommandBar renders commands correctly 1`] = `
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down Expand Up @@ -407,7 +407,7 @@ exports[`CommandBar renders empty farItems correctly 1`] = `
flex-wrap: nowrap;
position: relative;
}
role="group"
role="none"
>
<div
className=
Expand Down

0 comments on commit 07e4870

Please sign in to comment.