fix(react-drawer): resolve TODOs (#29272)

microsoft · Sep 25, 2023 · 2828134 · 2828134
1 parent fbaba50
commit 2828134
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/change/@fluentui-react-drawer-acebb572-ecff-43ab-a690-b88362121ae8.json b/change/@fluentui-react-drawer-acebb572-ecff-43ab-a690-b88362121ae8.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "fix: resolve technical debts",
+  "packageName": "@fluentui/react-drawer",
+  "email": "marcosvmmoura@gmail.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-drawer/src/components/DrawerFooter/DrawerFooter.tsx b/packages/react-components/react-drawer/src/components/DrawerFooter/DrawerFooter.tsx
@@ -8,7 +8,7 @@ import { useDrawerFooterStyles_unstable } from './useDrawerFooterStyles.styles';
 import type { DrawerFooterProps } from './DrawerFooter.types';
 
 /**
- * DrawerFooter component - TODO: add more docs
+ * DrawerFooter provides a structured footer for the drawer component.
  */
 export const DrawerFooter: ForwardRefComponent<DrawerFooterProps> = React.forwardRef((props, ref) => {
   const state = useDrawerFooter_unstable(props, ref);

diff --git a/...onents/react-drawer/src/components/DrawerHeaderNavigation/DrawerHeaderNavigation.test.tsx b/...onents/react-drawer/src/components/DrawerHeaderNavigation/DrawerHeaderNavigation.test.tsx
@@ -9,8 +9,6 @@ describe('DrawerHeaderNavigation', () => {
     displayName: 'DrawerHeaderNavigation',
   });
 
-  // TODO add more tests here, and create visual regression tests in /apps/vr-tests
-
   it('renders a default state', () => {
     const result = render(<DrawerHeaderNavigation>Default DrawerHeaderNavigation</DrawerHeaderNavigation>);
     expect(result.container).toMatchInlineSnapshot(`

diff --git a/...react-components/react-drawer/src/components/DrawerHeaderTitle/DrawerHeaderTitle.test.tsx b/...react-components/react-drawer/src/components/DrawerHeaderTitle/DrawerHeaderTitle.test.tsx
@@ -26,8 +26,6 @@ describe('DrawerHeaderTitle', () => {
     disabledTests: ['component-has-static-classnames-object'],
   });
 
-  // TODO add more tests here, and create visual regression tests in /apps/vr-tests
-
   it('renders a default state', () => {
     const result = render(<DrawerHeaderTitle>Default DrawerHeaderTitle</DrawerHeaderTitle>);
     expect(result.container).toMatchInlineSnapshot(`

diff --git a/packages/react-components/react-drawer/src/components/DrawerInline/DrawerInline.test.tsx b/packages/react-components/react-drawer/src/components/DrawerInline/DrawerInline.test.tsx
@@ -14,8 +14,6 @@ describe('DrawerInline', () => {
     disabledTests: ['make-styles-overrides-win'],
   });
 
-  // TODO add more tests here, and create visual regression tests in /apps/vr-tests
-
   it('renders a default state', () => {
     const result = render(<DrawerInline>Default Drawer</DrawerInline>);
     expect(result.container).toMatchInlineSnapshot(`<div />`);