mem leak fix

microsoft · May 25, 2021 · 4ef5126 · 4ef5126
1 parent d97c1a0
commit 4ef5126
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/packages/react-utilities/src/hooks/useOnClickOutside.ts b/packages/react-utilities/src/hooks/useOnClickOutside.ts
@@ -33,6 +33,7 @@ export type UseOnClickOutsideOptions = {
  */
 export const useOnClickOutside = (options: UseOnClickOutsideOptions) => {
   const { refs, callback, element, disabled, contains: containsProp } = options;
+  const timeoutId = React.useRef<number | undefined>(undefined);
 
   const listener = useEventCallback((ev: MouseEvent | TouchEvent) => {
     const contains: UseOnClickOutsideOptions['contains'] =
@@ -65,9 +66,17 @@ export const useOnClickOutside = (options: UseOnClickOutsideOptions) => {
       element?.addEventListener('touchstart', conditionalHandler);
     }
 
+    // Garbage collect this event after it's no longer useful to avoid memory leaks
+    timeoutId.current = setTimeout(() => {
+      currentEvent = undefined;
+    }, 1);
+
     return () => {
       element?.removeEventListener('click', conditionalHandler);
       element?.removeEventListener('touchstart', conditionalHandler);
+
+      clearTimeout(timeoutId.current);
+      currentEvent = undefined;
     };
   }, [listener, element, disabled]);
 };