remove formResetCallback override for checkbox indeterminate state

microsoft · Jul 2, 2024 · 5024cc9 · 5024cc9
1 parent 09850a3
commit 5024cc9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 14 deletions.
diff --git a/packages/web-components/src/checkbox/checkbox.spec.ts b/packages/web-components/src/checkbox/checkbox.spec.ts
@@ -239,11 +239,14 @@ test.describe('Checkbox', () => {
     await expect(element).toHaveJSProperty('indeterminate', false);
   });
 
-  test('should clear the `indeterminate` state when the `checked` property is true', async ({ page }) => {
+  test('should NOT change the `indeterminate` property when the owning form is reset', async ({ page }) => {
     const element = page.locator('fluent-checkbox');
+    const form = page.locator('form');
 
     await page.setContent(/* html */ `
-        <fluent-checkbox></fluent-checkbox>
+        <form>
+            <fluent-checkbox></fluent-checkbox>
+        </form>
     `);
 
     await element.evaluate((node: Checkbox) => {
@@ -252,9 +255,23 @@ test.describe('Checkbox', () => {
 
     await expect(element).toHaveJSProperty('indeterminate', true);
 
-    await element.press(' ');
+    await form.evaluate((node: HTMLFormElement) => {
+      node.reset();
+    });
+
+    await expect(element).toHaveJSProperty('indeterminate', true);
+
+    await test.step('should retain the `indeterminate` property after being set to `false` via user interaction', async () => {
+      await element.click();
 
-    await expect(element).toHaveJSProperty('indeterminate', false);
+      await expect(element).toHaveJSProperty('indeterminate', false);
+
+      await form.evaluate((node: HTMLFormElement) => {
+        node.reset();
+      });
+
+      await expect(element).toHaveJSProperty('indeterminate', false);
+    });
   });
 
   test('should initialize to the initial value if no value property is set', async ({ page }) => {

diff --git a/packages/web-components/src/checkbox/checkbox.ts b/packages/web-components/src/checkbox/checkbox.ts
@@ -554,16 +554,6 @@ export class Checkbox extends BaseCheckbox {
     this.elementInternals.role = 'checkbox';
   }
 
-  /**
-   * Resets the form value to its initial value when the form is reset.
-   *
-   * @internal
-   */
-  formResetCallback(): void {
-    this.indeterminate = false;
-    super.formResetCallback();
-  }
-
   /**
    * Toggles the checked state of the control.
    *