Hotfix/portal memory leak (#26435)

* clean virtual parent reference * changelog * reuse setVirtual and remove cleanVirtualParent
microsoft · Jan 23, 2023 · f644027 · f644027
1 parent 294d8a7
commit f644027
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/change/@fluentui-react-portal-cc923a38-5b66-41a7-95fb-306fefd5e3f4.json b/change/@fluentui-react-portal-cc923a38-5b66-41a7-95fb-306fefd5e3f4.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "clean up parent reference to avoid memory leaks",
+  "packageName": "@fluentui/react-portal",
+  "email": "arthurd@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-portal/src/components/Portal/usePortal.ts b/packages/react-components/react-portal/src/components/Portal/usePortal.ts
@@ -26,6 +26,9 @@ export const usePortal_unstable = (props: PortalProps): PortalState => {
     if (state.virtualParentRootRef.current && state.mountNode) {
       setVirtualParent(state.mountNode, state.virtualParentRootRef.current);
     }
+    return () => {
+      if (state.mountNode) {setVirtualParent(state.mountNode, undefined);}
+    };
   }, [state.virtualParentRootRef, state.mountNode]);
 
   return state;