Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @fluentui/react code examples in styles section of website #13382

Closed
ecraig12345 opened this issue May 28, 2020 · 2 comments
Closed

Update @fluentui/react code examples in styles section of website #13382

ecraig12345 opened this issue May 28, 2020 · 2 comments
Assignees

Comments

@ecraig12345
Copy link
Member

The website styles section currently does not have good information about how we actually recommend that people do styling with Fluent UI React. Some individual things that need to be fixed (non-exhaustive list):

  1. Replace @uifabric/fluent-theme references with @uifabric/styling where possible.
  • A few constants are not currently exported from the styling package. We should probably move them there so people can entirely stop referencing @uifabric/fluent-theme.
  1. Add examples of how we actually want people to do styling--getting values such as colors and font sizes from the theme, not constants.
  2. Some pages (example) have zero implementation info because they're just meant for reference and not available as variables. We should probably add a skeleton implementation section noting this.
  3. The Layout page needs a note about Stack vs grid--see Add note about grid vs Stack to layout styles page on website #13380
@ecraig12345
Copy link
Member Author

Improved somewhat in #14545 but still needs work.

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants