Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is very confusing #13200

Closed
Pearseak opened this issue May 17, 2020 · 4 comments
Closed

Documentation is very confusing #13200

Pearseak opened this issue May 17, 2020 · 4 comments
Assignees
Labels
Area: Documentation Needs: Backlog review Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@Pearseak
Copy link

I'm angular material web dev trying this fluent UI react but I found this framework is very confusing.

  1. What are the differences between Fluent UI React and Fluent UI Northstar? They have separate docs if they are sperate lib why bother putting them in the same readme.md or they aren't??? submodule?? I don't know.

  2. https://developer.microsoft.com/en-us/fluentui#/styles does not have any actual usage example and most of them don't even work if I just "npm install @fluentui/react" which is the only instruction in "Get started Web".It took me 2 days before I found out that I can't use Grid and I need to use Stack.

  3. Fabric core and Fluent UI are not interchangeable. Why do you put their docs together under web tag, it very irritates me because I don't know which part of them are not intersect

  4. I saw at least 3 different lib was import office-ui-fabric-react, @uifabric, @fluentui dude....seriously..

  5. how can I add animation to "Controls" should I use that class in motion docs? what about that react var? where should I put them? do they have token or I can just shove them in css file? or should I use standard css animation?

just a note from someone who came from different framework entirely

@kaplas
Copy link

kaplas commented May 28, 2020

I'd like to confirm @Pearseak 's observations. I looked into your Fluent/Fabric/whatever React controls in the spring, and thought I would like to use those in a project. Now when a suitable project started, everything regarding the documentation, what package to use, and so on seems really confusing.

@ecraig12345 ecraig12345 changed the title Documents are very confusing Documentation is very confusing May 28, 2020
@ecraig12345
Copy link
Member

ecraig12345 commented May 28, 2020

Sorry about the delay, thought I'd responded to this one (we did talk about it internally) but I guess not.

  1. @fluentui/react version 7 is what used to be known as Office UI Fabric React. It's widely used in Microsoft products and some outside. @fluentui/react-northstar (sometimes also called Fluent UI React v0) is what used to be known as Stardust and is mostly used by Microsoft Teams and Teams add-ins. They're in the same repo because we're working on converging them. More on that here.

    If you're wondering which one to use, the short answer right now is that unless you're developing for Teams (or making a chat/video-centric experience) you should use @fluentui/react, due to its more stable API (@fluentui/react-northstar due to being v0 may have API breaks in monthly minor releases) and wide usage.

    Related to this, we have issue Examples should import from @fluentui/react #13125 about updating imports in website examples to be from @fluentui/react, and Update wiki to reference react-northstar contributing docs #13283 about updating the wiki to point to the contributing docs specific to @fluentui/react-northstar. I also just made Update repo readme with info about @fluentui/react vs. @fluentui/react-northstar #13381 about updating the main repo readme with more info about the distinction and what to use when.

  2. Sorry about the confusing info on styling! This is definitely something we need to improve. I made Add note about grid vs Stack to layout styles page on website #13380 about Stack vs grid and Update @fluentui/react code examples in styles section of website #13382 for more general issues.

  3. It's possible to use Fluent UI React and Fabric Core together, but I agree we should have clearer guidance about what to use when and the lack of feature parity. Made an issue Clarify docs about Fabric Core vs Fluent UI React #13383 about this.

  4. The different package names and scopes are essentially for historical reasons:

    • office-ui-fabric-react is the old name of the package now known as @fluentui/react. At one point all the code that's now in sub-packages lived here before it was converted to monorepo/multi-package structure.
    • @uifabric packages are the sub-packages of office-ui-fabric-react (now @fluentui/react) that we added after converting to monorepo structure, but before the Fluent UI rename. (We'd probably like to move these to @fluentui scope but this may not happen immediately--see Move @uifabric packages under @fluentui scope #13384).
    • @fluentui is the new scope that we want all packages to live under. New sub-packages for @fluentui/react and the eventual converged library are being created under this scope, but it also contains some sub-packages which are currently more specific to @fluentui/react-northstar (generally these are the ones that live under packages/fluentui in the repo--this is a distinction we need to clarify better in the repo readme).
    • The examples on the website need to be updated to import from @fluentui/react rather than office-ui-fabric-react--there's a work item Examples should import from @fluentui/react #13125 for this.
  5. We don't have a good story for adding animations to controls right now. This has been discussed under Animation documentation is lacking #9863 but was never resolved.

@marcosteam
Copy link

Yup, the document is very confused.I don't know how to get the point.

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Documentation Needs: Backlog review Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

7 participants