Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Integrate makeStyles in react-button's Button #16820

Closed
khmakoto opened this issue Feb 4, 2021 · 3 comments · Fixed by #17060
Closed

Button: Integrate makeStyles in react-button's Button #16820

khmakoto opened this issue Feb 4, 2021 · 3 comments · Fixed by #17060
Assignees
@levithomason @khmakoto
Labels
Component: Button Status: Fixed Fixed in some PR

Comments

@khmakoto
Copy link
Member

khmakoto commented Feb 4, 2021

We should rework the Button inside @fluentui/react-button to make use of the new makeStyles in a similar fashion of what is being done in #16793 for Avatar.
@khmakoto khmakoto mentioned this issue Feb 4, 2021
Closed
37 tasks
@khmakoto khmakoto mentioned this issue Feb 24, 2021
Merged
2 tasks
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Feb 25, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17060, which has now been successfully released as @fluentui/react-components@v9.0.0-alpha.3.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17060, which has now been successfully released as @fluentui/react-button@v9.0.0-alpha.3.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #17060, which has now been successfully released as @fluentui/react-examples@v8.0.0-beta.10.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@levithomason levithomason

@khmakoto khmakoto

Labels
Component: Button Status: Fixed Fixed in some PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update react-button for preview release levithomason/fluentui
3 participants
@levithomason @khmakoto @msft-fluent-ui-bot