Update react-button for preview release #17060
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ef0ab3:
|
| } catch (err) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(err); | ||
| } |
There was a problem hiding this comment.
This PR is also adding static styles for normalize.css, box-sizing, and font faces. This change is required to allow those to render.
There was a problem hiding this comment.
This change was revert in 69597b0, correct?
packages/react-button/src/components/Button/useButtonClasses.ts
Outdated
Show resolved
Hide resolved
|
We should probably link (if not outright fix) #16820 with this PR. |
|
Addressed all feedback and added vr-tests. The rest of the TODOs I'd like to address in a fast follow but go ahead and get some early feedback on this. Looking to merge tomorrow USA time. |
…eat/converged-button-preview
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
* scaffold stories from figma * begin adding react-button converged tokens * add more button tokens to makestyles call * continue adding variants and their tokens * continue adding variants and their tokens * fix icon spacing update button token dump * rework component token table * more button tokens * fix statics and tokens * add more todo for static styles, need to wire hook * used tokens storybook addon * start resolving token panel values * FluentTokens addon: debug theme encapsulated * initial cleanup for button prerelease and storybook * initial cleanup for button prerelease and storybook * clean up cruft * more cleanup * you guessed it, more clean up * ... * ... * delete bunch of stuff * delete bunch of stuff * add todo * remove data-is-focusable * merge master, fix issues * stub disabled tokens, fix issues * Disabled styles * move todos to proper line * comment out unsupported props * clean up todos * revert react-provider changes * remove todo * remove static styles * fix typings * make react-button build * fix tests * restore web components from master * restore react-utilities from master * fix props typing, sync tsconfig with react-link * miro fixes levi * api changes * Change files * remove duplicate packages in storybook preview.js * remove unused style matchers * fix button props, add vr-tests * fix vr-test typings * fix icon package name merge issue * rename useButtonClasses to useButtonStyles * remove unused css variables * add todo for gap and fix remaining useClasses names * fix versions * fix API * fix typings * delete stories for compat Provider Co-authored-by: Miroslav Stastny <miroslav.stastny@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
Update react-button for preview release
Pull request checklist
$ yarn changeDescription of changes
Removes all non-converged apis and concepts from react-button. Updates react-button to adhere to Fluent UI design specs.
Fixes #16820
Focus areas to test
Run the storybook, check examples. Consider alignment to design specs and general expected behavior.