Button: Beefing up accessibility tests and cleaning up state management #17155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khmakoto
requested review from
levithomason,
miroslavstastny,
jurokapsiar,
layershifter and
behowell
khmakoto
requested review from
assuncaocharles,
dzearing,
kolaps33,
ling1726 and
pompomon
as code owners
This was referenced Feb 24, 2021
Closed
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a4d3a27:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0913259cdea5a3d692720299516aec613b7c072a (build) |
@layershifter yeah, let's do that. I've added the |
khmakoto
commented
Feb 25, 2021
Comment on lines
+9
to
+13
| // BehaviorRule.root() | ||
| // .forProps({ href: '#' }) | ||
| // .hasAttribute('role', 'button') | ||
| // .hasAttribute('tabindex', '0') | ||
| // .description(`if element has href and is rendered as an 'anchor'.`), |
There was a problem hiding this comment.
Just wanted to know that I've commented for now the tests that reference commented props.
There was a problem hiding this comment.
might be worth adding that somewhere in this definition
|
Now that #17169 (final version 8 prep) has merged, you'll need to merge with master and update any "prerelease" change files to use either "patch" or "minor" as appropriate. |
msft-fluent-ui-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
…nction (#17086) #### Pull request checklist - [x] Addresses an existing issue: Part of #16572 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR does a couple of things: - Adds vr-tests for the `Link` component in the `vr-tests` package. - Adds accessibility tests for the `Link` component as `linkBehaviorDefinition` in the `@fluentui/a11y-testing` package. - Cleans up the `useLinkState` hook and fixes some issues with it under the `@fluentui/react-link` package. - Adds behavioral and snapshot tests in the `@fluentui/react-link` package. - ~Cleans up the `buttonBehaviorDefinition` tests in the `@fluentui/a11y-testing` package.~ (Moved to #17155) - ~Cleans up the `useButtonState` hook and some of the tests under the `@fluentui/react-button` package.~ (Moved to #17155)
behowell
approved these changes
Mar 12, 2021
| draftState.disabled = draftState.as === 'button' ? disabled /* && !disabledFocusable */ : undefined; | ||
| // Set the aria-disabled and disabled props correctly. | ||
| state['aria-disabled'] = disabled /*|| disabledFocusable*/; | ||
| state.disabled = as === 'button' ? disabled /* && !disabledFocusable*/ : undefined; |
There was a problem hiding this comment.
Will as ever be undefined, or does it get defaulted to 'button' somewhere?
There was a problem hiding this comment.
It gets defaulted in the useButton hook before calling useButtonState.
dzearing
reviewed
Mar 25, 2021
| @@ -4,40 +4,56 @@ import { ButtonState } from './Button.types'; | |||
|
|
|||
| /** | |||
| * The useButton hook processes the Button draft state. | |||
| * @param draftState - Button draft state to mutate. | |||
| * @param state - Button draft state to mutate. | |||
There was a problem hiding this comment.
On thing here is that judging from naming, i originally was thinking draftState rather than simply state as a variable name would be a better indication that the object will be mutated. Otherwise, especially now that it returns the state, it might be interpreted to not mutate like normal circumstances.
There was a problem hiding this comment.
The comment is pretty clear that it mutates it of course, just not everyone thoroughly reads comments but they do read param names and might infer an expectation.
If there's a better term than draftState, maybe partialState or something... that is more clear, I think that would be better than calling it just state. My 2c
There was a problem hiding this comment.
I was using the convention that the other components have gone with. I can push back to get some better naming but that should probably not block this PR.
dzearing
approved these changes
Mar 25, 2021
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…nction (microsoft#17086) #### Pull request checklist - [x] Addresses an existing issue: Part of microsoft#16572 - [x] Include a change request file using `$ yarn change` #### Description of changes This PR does a couple of things: - Adds vr-tests for the `Link` component in the `vr-tests` package. - Adds accessibility tests for the `Link` component as `linkBehaviorDefinition` in the `@fluentui/a11y-testing` package. - Cleans up the `useLinkState` hook and fixes some issues with it under the `@fluentui/react-link` package. - Adds behavioral and snapshot tests in the `@fluentui/react-link` package. - ~Cleans up the `buttonBehaviorDefinition` tests in the `@fluentui/a11y-testing` package.~ (Moved to microsoft#17155) - ~Cleans up the `useButtonState` hook and some of the tests under the `@fluentui/react-button` package.~ (Moved to microsoft#17155)
ling1726
approved these changes
Mar 25, 2021
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…nt (microsoft#17155) * Button: Beefing up accessibility tests and cleaning up state management. * Change files * Updating change file. * Updating snapshots. * Removing unused imports. * Fixing lint error. Co-authored-by: KHMakoto <humberto_makoto@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR does a couple of things:
Buttoncomponent under the@fluentui/a11y-testingpackage.useButtonStatehook and some of the tests under the@fluentui/react-buttonpackage.