Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components] Add appearance behaviors for inputs and form controls #17558

Closed
chrisdholt opened this issue Mar 24, 2021 · 4 comments
Closed

Comments

@chrisdholt
Copy link
Member

We recently added an appearance behavior to conditionally load stylesheets for various button appearances: https://github.com/microsoft/fluentui/pull/17516/files. There are several other controls which also have appearances where this behavior should be included as well.

This issue exists to track the addition of appearance behaviors for:

  • text field
  • text area
  • number field
  • select
  • combobox
@Jassi10000-zz
Copy link

Is this related to form valdations ?

@chrisdholt
Copy link
Member Author

Is this related to form valdations ?

Not yet! This is in regards to the existing visual appearances (outline, filled) and improved performance. Behaviors allow us to include or exclude styles conditionally. In this work, we're conditionally including and attaching an adopted stylesheet when a given appearance exists. This way, if you don't use the "filled" appearance, it's not rendered into the document as an adopted stylesheet.

@Jassi10000-zz
Copy link

Jassi10000-zz commented Mar 25, 2021

Ohh , that's something interesting to know, thanks for info @chrisdholt

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 4, 2022
@chrisdholt chrisdholt removed the Resolution: Soft Close Soft closing inactive issues over a certain period label Feb 5, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants