feat: add appearance behaviors for inputs and form controls #17565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khamudom
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d1a4faf:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ce4d441da2c63284a2c1c519a59875c22cd3552f (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khamudom
force-pushed
the
users/khamu/inputs-form-appearance-behavior
branch
from
e3eedc2
to
f667a51
Compare
nicholasrice
approved these changes
Mar 25, 2021
|
closes #17558 |
chrisdholt
reviewed
Mar 25, 2021
| neutralFillRestBehavior, | ||
| forcedColorsStylesheetBehavior( | ||
| css` | ||
| :host(.filled) .root { |
There was a problem hiding this comment.
@khamudom while we're here - can you update all instances of these so they target the appearance attribute?
chrisdholt
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Looks good - thanks @khamudom! I see one bug visually in number field but it's unrelated to your PR, so I'll make that change separately :)
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…t#17565) * create a separate css block for filled appearance and add appearanceBehavior * Change files * update import order in combobox and removed unused import in textarea * update to use appearance attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Created a separate CSS object that targets the
appearance="filled"attribute and applied it toappearanceBehaviors.The components updated are:
Combobox
Select
Number field
Text area
Text field
Focus areas to test
(optional)