Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storybook: running sb with new DX for vNext is causing lot of babel warnings #18917

Closed
Hotell opened this issue Jul 13, 2021 · 1 comment
Closed

storybook: running sb with new DX for vNext is causing lot of babel warnings #18917

Hotell opened this issue Jul 13, 2021 · 1 comment
Labels
Area: Build System dependencies Pull requests that update a dependency file Needs: Triage 🔍 Status: Fixed Fixed in some PR Storybook
Milestone
August Project Cy...

Comments

@Hotell
Copy link
Contributor

Hotell commented Jul 13, 2021 •
edited
Loading

Describe the issue:

Curent behaviour:

yarn workspace @fluentui/react-menu storybook

↓↓↓↓

2021-07-08 at 18 10

Expected behaviour:

2021-07-08 at 18 11

Why is this happening:

  • storybooks babel config doesn't set babel-preset/env loose:true , which triggers gazilion of warnings when running storybook as our root babel.config.js sets dependant plugins to loose mode
  • storybook 6.3 uses now loose mode so that should fix this for good without any change from our side chore: migrate to latest storybook 6.2.x #18142
@Hotell Hotell added this to the July Project Cycle Q2 2021 milestone Jul 13, 2021
@Hotell Hotell added Area: Build System dependencies Pull requests that update a dependency file Storybook labels Jul 13, 2021
@Hotell Hotell mentioned this issue Jul 13, 2021
Closed
3 tasks
@Hotell Hotell changed the title storybook: running sb with new DX for vNext is causing ton of babel warnings storybook: running sb with new DX for vNext is causing lot of babel warnings Jul 13, 2021
@ling1726 ling1726 removed their assignment Jul 13, 2021
@Hotell Hotell mentioned this issue Aug 2, 2021
Merged
2 tasks
@msft-fluent-ui-bot msft-fluent-ui-bot added the Status: Fixed Fixed in some PR label Aug 2, 2021
@Hotell
Copy link
Contributor Author

Hotell commented Aug 2, 2021

Fixed by #19166

@Hotell Hotell closed this as completed Aug 2, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Build System dependencies Pull requests that update a dependency file Needs: Triage 🔍 Status: Fixed Fixed in some PR Storybook
Projects
None yet
Milestone
August Project Cycle Q3 2021
Development

No branches or pull requests
3 participants
@Hotell @ling1726 @msft-fluent-ui-bot