Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to latest storybook 6.2.x #18142

Closed
Hotell opened this issue May 11, 2021 · 1 comment · Fixed by #18693
Closed

chore: migrate to latest storybook 6.2.x #18142

Hotell opened this issue May 11, 2021 · 1 comment · Fixed by #18693
Assignees
@TristanWatanabe
Labels
Area: Build System Priority 2: Normal Status: Fixed Fixed in some PR
Milestone
June Project Cycl...

Comments

@Hotell
Copy link
Contributor

Hotell commented May 11, 2021

Description

we are currently at 6.0.x

To leverage latest features that are being added to SB we wanna stay up to date.

Also being on latest will help us troubleshoot any issues we might run into (a11y/plugins/etc...)

Things to be aware while migrating:

Steps to verify that migration worked

  • CI passes
  • run yarn workspace @fluentui/react-menu storybook and check that everything works
  • run yarn workspace @fluentui/react-components start and check that everything works
@Hotell Hotell added this to the May Project Cycle Q2 2021 milestone May 11, 2021
@Hotell Hotell changed the title chore: migrate to latest storybook 6.3 chore: migrate to latest storybook 6.2.x May 20, 2021
@Hotell Hotell mentioned this issue Jun 9, 2021
Merged
2 tasks
@TristanWatanabe TristanWatanabe mentioned this issue Jun 24, 2021
Merged
2 tasks
@Hotell Hotell mentioned this issue Jul 13, 2021
Closed
msft-fluent-ui-bot pushed a commit that referenced this issue Jul 22, 2021
@TristanWatanabe
Migrate storybook to 6.2.9 (#18693)
5fcdb72 
#### Pull request checklist

- [x] Addresses an existing issue: Fixes #18142
- [x] Include a change request file using `$ yarn change`

#### Description of changes
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Jul 22, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18693, which has now been successfully released as @fluentui/react-popover@v9.0.0-alpha.20.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this issue Aug 6, 2021
@TristanWatanabe @PeterDraex
Migrate storybook to 6.2.9 (microsoft#18693)
4984e4e 
#### Pull request checklist

- [x] Addresses an existing issue: Fixes microsoft#18142
- [x] Include a change request file using `$ yarn change`

#### Description of changes
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TristanWatanabe TristanWatanabe

Labels
Area: Build System Priority 2: Normal Status: Fixed Fixed in some PR
Projects
None yet
Milestone
June Project Cycle Q2 2021
Development

Successfully merging a pull request may close this issue.

Migrate storybook to 6.2.9 TristanWatanabe/fluentui
3 participants
@Hotell @TristanWatanabe @msft-fluent-ui-bot