(web-components) update neutral fill card vNext #18444
Conversation
bheston
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
| @@ -5,7 +5,7 @@ import { findClosestSwatchIndex, getSwatch } from './palette'; | |||
| const neutralCardFillAlgorithm: SwatchResolver = (designSystem: DesignSystem): Swatch => { | |||
| const offset: number = neutralFillCardDelta(designSystem); | |||
| const index: number = findClosestSwatchIndex(neutralPalette, backgroundColor(designSystem))(designSystem); | |||
| return getSwatch(index - (index < offset ? offset * -1 : offset), neutralPalette(designSystem)); | |||
There was a problem hiding this comment.
Ideally this update comes in from a rebase w/ master. Can you remove these in favor of just the color-vNext work? That'll keep everything conflict free.
There was a problem hiding this comment.
Just one request to pull the stuff that's in master already as it'll come in w/ rebase.
Thanks @bheston!
|
@chrisdholt I considered the rebase, but needed the changes local for the tests to run. My thought was if the changes were exact it wouldn't cause an issue during rebase. |
Gotcha - I'll see if I can do a quick rebase today and have it fall off. |
chrisdholt
force-pushed
the
features/web-components-vNext
branch
from
b013a96 to
a5e0caf
Compare
packages/web-components/package.json
Outdated
| "@storybook/cli": "^5.3.8", | ||
| "@storybook/html": "^5.3.8", | ||
| "@storybook/theming": "^5.3.8", | ||
| "@storybook/addons": "^6.1.17", |
There was a problem hiding this comment.
hey folks! would you be satisfied to use storybook 6.0.28 for now ? We plan to migrate to latest in June #18142 so we could be all on the same version -> getting close to single version policy for tooling in monorepo + shorter installation times
pls lemme know, thx
There was a problem hiding this comment.
I'm fine with this, though I think this change is likely coming from rebasing the feature branch w/ master. We'll likely need to make this change in a new PR.
@bheston can you rebase w/ the feature branch? That should clean up the commit history and files here :)
…osoft#18187) * update accordion to use foundation element * update anchor to extend foundation element * update anchored region to extend foundation element * correct style exports * update badge to extend foundation * update breadcrumb to extend foundation element * update button to extend foundation element * update checkbox to extend foundation element * update combobox to extend foundation element * update dialog to extend foundation element * update divider styles * update flipper to extend foundation element * update horizontal scroll to extend foundation element * update listbox to extend foundation element * update listbox option to extend foundation element * update naming for exported registries * update menu and menu item to extend foundation * aupdate number field to extend foundation element * update progress to extend foundation element * update radio, radiogroup and select to extend foundation el * update skeleton to extend foundation element * update slider to extend foundation element * update switch to extend foundation component * correct prefix for export names * update text area to extend foundation element * update text field to extend foundation * update tooltip to extend foundation element * update tree view to extend foundation element * update comments v1 * export all custom element definitions * exportfluent design system and definitions from rollup * add data grid * update fast to fluent in rollup * add beta package to start updating w/ foundation element * update stories files * Change files
…ual to the container, instead of flipping to go darker over white.
bheston
force-pushed
the
update-neutral-fill-card-vNext
branch
from
2137006 to
a377ea6
Compare
* Updated the neutral fill card color recipe to always be lighter or equal to the container, instead of flipping to go darker over white. * Updated old recipe and tests * Run `yarn build` * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
* Updated the neutral fill card color recipe to always be lighter or equal to the container, instead of flipping to go darker over white. * Updated old recipe and tests * Run `yarn build` * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
* Updated the neutral fill card color recipe to always be lighter or equal to the container, instead of flipping to go darker over white. * Updated old recipe and tests * Run `yarn build` * Change files Co-authored-by: Chris Holt <chhol@microsoft.com>
Pull request checklist
$ yarn changeDescription of changes
Updated the neutral fill card color recipe to always be lighter or equal to the container, instead of flipping to go darker over white.
Focus areas to test
(optional)