Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Accordion item is collapsed by clicking on components inside it's content #24561

Closed
2 tasks done
chroustak1 opened this issue Aug 29, 2022 · 5 comments · Fixed by #24657
Closed
2 tasks done

[Bug]: Accordion item is collapsed by clicking on components inside it's content #24561

chroustak1 opened this issue Aug 29, 2022 · 5 comments · Fixed by #24657
Assignees
Labels

Comments

@chroustak1
Copy link

Library

Web Components (@fluentui/web-components)

System Info

Windows

Are you reporting Accessibility issue?

no

Reproduction

https://codesandbox.io/s/practical-hamilton-6cv6vs?file=/index.html

Bug Description

Actual Behavior

Accordion items placed inside an accordion with expand-mode=single are collapsed by clicking on a component (e.g. checkbox, another sub accordion item) placed inside its content.
image

Expected Behavior

Clicking on a component inside an accordion item content will not collapse the accordion item.

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@chrisdholt
Copy link
Member

This has been fixed in our vNext branches but a PR is here to cherry-pick into the current releases: https://github.com/microsoft/fast/pull/6332/files

@chroustak1 are you pulling the packages in via NPM or from CDN?

@chroustak1
Copy link
Author

@chrisdholt - I'm using CDN (https://cdn.jsdelivr.net/npm/@@fluentui/web-components)

And thanks for super fast reply :)

@chrisdholt
Copy link
Member

@chrisdholt - I'm using CDN (https://cdn.jsdelivr.net/npm/@@fluentui/web-components)

And thanks for super fast reply :)

Thank you! I'll go ahead and force a package update and get it published out. This was fixed for our vNext implementation so a cherry-pick and update of the fast-foundation packages here will solve the issue. I'm going to try and get an additional fix in, but if it's not done by tomorrow we'll expedite this for you. Thanks!

@chrisdholt
Copy link
Member

The PR containing this fix has been merged. A new version should be published and pushed to the CDN automatically tomorrow AM PST. Thanks!

@chroustak1
Copy link
Author

New version is working flawlessly. Thank you.

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants