Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fast-foundation to resolve 24561 #24657

Conversation

chrisdholt
Copy link
Member

Related Issue(s)

Fixes #24561

Fixes #

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db8cbd0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
inspiring-https-krd78c Issue #24561

@size-auditor
Copy link

size-auditor bot commented Sep 2, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6bc03a4e9ee815da750466f9dc2d25df1373f3e9 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1582 1581 5000
Button mount 1152 1169 5000
FluentProvider mount 1883 1855 5000
FluentProviderWithTheme mount 760 753 10
FluentProviderWithTheme virtual-rerender 701 704 10
FluentProviderWithTheme virtual-rerender-with-unmount 740 754 10
MakeStyles mount 2297 2242 50000
SpinButton mount 3007 3000 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.349 kB
24.053 kB
react-alert
Alert
83.739 kB
20.823 kB
react-avatar
Avatar
48.281 kB
13.647 kB
react-avatar
AvatarGroup
14.85 kB
5.942 kB
react-avatar
AvatarGroupItem
68.249 kB
18.99 kB
react-badge
Badge
22.5 kB
7.158 kB
react-badge
CounterBadge
23.403 kB
7.45 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.347 kB
9.559 kB
react-button
CompoundButton
43.373 kB
10.775 kB
react-button
MenuButton
38.965 kB
10.438 kB
react-button
SplitButton
46.495 kB
11.82 kB
react-button
ToggleButton
51.861 kB
10.983 kB
react-card
Card - All
67.458 kB
19.264 kB
react-card
Card
63.14 kB
18.176 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
73.757 kB
23.969 kB
react-combobox
Dropdown (including child components)
73.344 kB
23.876 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.767 kB
51.885 kB
react-components
react-components: FluentProvider & webLightTheme
33.259 kB
10.952 kB
react-dialog
Dialog (including children components)
85.361 kB
25.458 kB
react-divider
Divider
16.359 kB
5.853 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.498 kB
7.617 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.231 kB
4.925 kB
react-menu
Menu (including children components)
115.697 kB
35.316 kB
react-menu
Menu (including selectable components)
118.896 kB
35.806 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.835 kB
31.498 kB
react-portal
Portal
10.576 kB
3.875 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.655 kB
5.835 kB
react-radio
Radio
36.025 kB
11.914 kB
react-radio
RadioGroup
14.148 kB
5.654 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
32.07 kB
10.033 kB
react-spinbutton
SpinButton
43.843 kB
12.336 kB
react-spinner
Spinner
19.877 kB
6.392 kB
react-switch
Switch
32.562 kB
10.253 kB
react-text
Text - Default
11.682 kB
4.561 kB
react-text
Text - Wrappers
14.992 kB
4.995 kB
react-textarea
Textarea
23.674 kB
7.83 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.548 kB
6.434 kB
react-theme
Teams: Light theme
17.452 kB
5.054 kB
react-tooltip
Tooltip
41.502 kB
14.623 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 6bc03a4e9ee815da750466f9dc2d25df1373f3e9

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
DividerMinimalPerf.default 321 298 1.08:1
AlertMinimalPerf.default 228 216 1.06:1
ChatWithPopoverPerf.default 312 295 1.06:1
AttachmentSlotsPerf.default 898 857 1.05:1
ChatDuplicateMessagesPerf.default 234 222 1.05:1
ListCommonPerf.default 532 506 1.05:1
FlexMinimalPerf.default 257 246 1.04:1
PortalMinimalPerf.default 145 140 1.04:1
AnimationMinimalPerf.default 482 470 1.03:1
ButtonSlotsPerf.default 428 415 1.03:1
DropdownManyItemsPerf.default 564 548 1.03:1
GridMinimalPerf.default 306 296 1.03:1
ChatMinimalPerf.default 637 626 1.02:1
DialogMinimalPerf.default 700 687 1.02:1
LabelMinimalPerf.default 334 326 1.02:1
LayoutMinimalPerf.default 317 311 1.02:1
LoaderMinimalPerf.default 542 530 1.02:1
ReactionMinimalPerf.default 335 329 1.02:1
RefMinimalPerf.default 190 186 1.02:1
SkeletonMinimalPerf.default 309 302 1.02:1
TableMinimalPerf.default 356 350 1.02:1
CardMinimalPerf.default 461 457 1.01:1
CarouselMinimalPerf.default 364 359 1.01:1
HeaderMinimalPerf.default 318 315 1.01:1
InputMinimalPerf.default 992 987 1.01:1
ItemLayoutMinimalPerf.default 987 981 1.01:1
MenuMinimalPerf.default 743 736 1.01:1
MenuButtonMinimalPerf.default 1361 1342 1.01:1
RosterPerf.default 1703 1691 1.01:1
ProviderMinimalPerf.default 323 319 1.01:1
RadioGroupMinimalPerf.default 392 389 1.01:1
SegmentMinimalPerf.default 303 299 1.01:1
SliderMinimalPerf.default 1317 1309 1.01:1
StatusMinimalPerf.default 607 603 1.01:1
TableManyItemsPerf.default 1585 1566 1.01:1
AttachmentMinimalPerf.default 127 127 1:1
BoxMinimalPerf.default 301 302 1:1
CheckboxMinimalPerf.default 1944 1937 1:1
DropdownMinimalPerf.default 2552 2554 1:1
SplitButtonMinimalPerf.default 3321 3321 1:1
TextMinimalPerf.default 295 296 1:1
CustomToolbarPrototype.default 2350 2358 1:1
ToolbarMinimalPerf.default 800 802 1:1
TooltipMinimalPerf.default 1893 1884 1:1
AccordionMinimalPerf.default 128 129 0.99:1
ButtonMinimalPerf.default 128 129 0.99:1
EmbedMinimalPerf.default 2981 3009 0.99:1
ImageMinimalPerf.default 340 344 0.99:1
ListNestedPerf.default 468 474 0.99:1
PopupMinimalPerf.default 559 564 0.99:1
ProviderMergeThemesPerf.default 979 992 0.99:1
TreeMinimalPerf.default 690 698 0.99:1
VideoMinimalPerf.default 627 632 0.99:1
ButtonOverridesMissPerf.default 1164 1185 0.98:1
DatepickerMinimalPerf.default 4584 4689 0.98:1
ListMinimalPerf.default 452 462 0.98:1
ListWith60ListItems.default 494 504 0.98:1
AvatarMinimalPerf.default 159 164 0.97:1
FormMinimalPerf.default 325 334 0.97:1
HeaderSlotsPerf.default 668 688 0.97:1
IconMinimalPerf.default 559 574 0.97:1
TextAreaMinimalPerf.default 404 415 0.97:1
TreeWith60ListItems.default 127 133 0.95:1

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 711 720 5000
Breadcrumb mount 2464 2390 1000
Checkbox mount 2139 2005 5000
CheckboxBase mount 1788 1746 5000
ChoiceGroup mount 3696 3639 5000
ComboBox mount 744 803 1000
CommandBar mount 8823 8859 1000
ContextualMenu mount 10470 9658 1000
DefaultButton mount 968 906 5000
DetailsRow mount 3002 3224 5000
DetailsRowFast mount 2986 2950 5000
DetailsRowNoStyles mount 2786 2780 5000
Dialog mount 2499 2520 1000
DocumentCardTitle mount 150 133 1000
Dropdown mount 2781 2526 5000
FocusTrapZone mount 1482 1452 5000
FocusZone mount 1475 1538 5000
IconButton mount 1401 1401 5000
Label mount 293 264 5000
Layer mount 3614 3533 5000
Link mount 388 358 5000
MenuButton mount 1137 1193 5000
MessageBar mount 1758 1744 5000
Nav mount 2627 2921 1000
OverflowSet mount 879 851 5000
Panel mount 1997 1915 1000
Persona mount 794 819 1000
Pivot mount 1113 1228 1000
PrimaryButton mount 999 984 5000
Rating mount 6094 6204 5000
SearchBox mount 1004 984 5000
Shimmer mount 2296 2354 5000
Slider mount 1545 1545 5000
SpinButton mount 4004 3942 5000
Spinner mount 326 314 5000
SplitButton mount 2388 2460 5000
Stack mount 427 386 5000
StackWithIntrinsicChildren mount 1732 1923 5000
StackWithTextChildren mount 4109 4021 5000
SwatchColorPicker mount 9437 9530 5000
TagPicker mount 2210 2042 5000
TeachingBubble mount 85331 84589 5000
Text mount 362 358 5000
TextField mount 1170 1030 5000
ThemeProvider mount 1038 1108 5000
ThemeProvider virtual-rerender 587 554 5000
ThemeProvider virtual-rerender-with-unmount 1617 1609 5000
Toggle mount 689 632 5000
buttonNative mount 103 119 5000

@chrisdholt
Copy link
Member Author

@Hotell any way you can get eyes on this small change? Fix just needed to be cherry-picked into stable and I've confirmed this resolves the issue. Since the person reporting is using the CDN, we have to push a fresh PR referencing the latest packages in order to automatically deploy another version. Thanks!

@chrisdholt chrisdholt merged commit 44bd582 into microsoft:master Sep 6, 2022
@chrisdholt chrisdholt deleted the users/chhol/fix-accordion-item-collapse-24561 branch September 6, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Accordion item is collapsed by clicking on components inside it's content
4 participants