-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fast-foundation to resolve 24561 #24657
update fast-foundation to resolve 24561 #24657
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db8cbd0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6bc03a4e9ee815da750466f9dc2d25df1373f3e9 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1582 | 1581 | 5000 | |
Button | mount | 1152 | 1169 | 5000 | |
FluentProvider | mount | 1883 | 1855 | 5000 | |
FluentProviderWithTheme | mount | 760 | 753 | 10 | |
FluentProviderWithTheme | virtual-rerender | 701 | 704 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 740 | 754 | 10 | |
MakeStyles | mount | 2297 | 2242 | 50000 | |
SpinButton | mount | 3007 | 3000 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
DividerMinimalPerf.default | 321 | 298 | 1.08:1 |
AlertMinimalPerf.default | 228 | 216 | 1.06:1 |
ChatWithPopoverPerf.default | 312 | 295 | 1.06:1 |
AttachmentSlotsPerf.default | 898 | 857 | 1.05:1 |
ChatDuplicateMessagesPerf.default | 234 | 222 | 1.05:1 |
ListCommonPerf.default | 532 | 506 | 1.05:1 |
FlexMinimalPerf.default | 257 | 246 | 1.04:1 |
PortalMinimalPerf.default | 145 | 140 | 1.04:1 |
AnimationMinimalPerf.default | 482 | 470 | 1.03:1 |
ButtonSlotsPerf.default | 428 | 415 | 1.03:1 |
DropdownManyItemsPerf.default | 564 | 548 | 1.03:1 |
GridMinimalPerf.default | 306 | 296 | 1.03:1 |
ChatMinimalPerf.default | 637 | 626 | 1.02:1 |
DialogMinimalPerf.default | 700 | 687 | 1.02:1 |
LabelMinimalPerf.default | 334 | 326 | 1.02:1 |
LayoutMinimalPerf.default | 317 | 311 | 1.02:1 |
LoaderMinimalPerf.default | 542 | 530 | 1.02:1 |
ReactionMinimalPerf.default | 335 | 329 | 1.02:1 |
RefMinimalPerf.default | 190 | 186 | 1.02:1 |
SkeletonMinimalPerf.default | 309 | 302 | 1.02:1 |
TableMinimalPerf.default | 356 | 350 | 1.02:1 |
CardMinimalPerf.default | 461 | 457 | 1.01:1 |
CarouselMinimalPerf.default | 364 | 359 | 1.01:1 |
HeaderMinimalPerf.default | 318 | 315 | 1.01:1 |
InputMinimalPerf.default | 992 | 987 | 1.01:1 |
ItemLayoutMinimalPerf.default | 987 | 981 | 1.01:1 |
MenuMinimalPerf.default | 743 | 736 | 1.01:1 |
MenuButtonMinimalPerf.default | 1361 | 1342 | 1.01:1 |
RosterPerf.default | 1703 | 1691 | 1.01:1 |
ProviderMinimalPerf.default | 323 | 319 | 1.01:1 |
RadioGroupMinimalPerf.default | 392 | 389 | 1.01:1 |
SegmentMinimalPerf.default | 303 | 299 | 1.01:1 |
SliderMinimalPerf.default | 1317 | 1309 | 1.01:1 |
StatusMinimalPerf.default | 607 | 603 | 1.01:1 |
TableManyItemsPerf.default | 1585 | 1566 | 1.01:1 |
AttachmentMinimalPerf.default | 127 | 127 | 1:1 |
BoxMinimalPerf.default | 301 | 302 | 1:1 |
CheckboxMinimalPerf.default | 1944 | 1937 | 1:1 |
DropdownMinimalPerf.default | 2552 | 2554 | 1:1 |
SplitButtonMinimalPerf.default | 3321 | 3321 | 1:1 |
TextMinimalPerf.default | 295 | 296 | 1:1 |
CustomToolbarPrototype.default | 2350 | 2358 | 1:1 |
ToolbarMinimalPerf.default | 800 | 802 | 1:1 |
TooltipMinimalPerf.default | 1893 | 1884 | 1:1 |
AccordionMinimalPerf.default | 128 | 129 | 0.99:1 |
ButtonMinimalPerf.default | 128 | 129 | 0.99:1 |
EmbedMinimalPerf.default | 2981 | 3009 | 0.99:1 |
ImageMinimalPerf.default | 340 | 344 | 0.99:1 |
ListNestedPerf.default | 468 | 474 | 0.99:1 |
PopupMinimalPerf.default | 559 | 564 | 0.99:1 |
ProviderMergeThemesPerf.default | 979 | 992 | 0.99:1 |
TreeMinimalPerf.default | 690 | 698 | 0.99:1 |
VideoMinimalPerf.default | 627 | 632 | 0.99:1 |
ButtonOverridesMissPerf.default | 1164 | 1185 | 0.98:1 |
DatepickerMinimalPerf.default | 4584 | 4689 | 0.98:1 |
ListMinimalPerf.default | 452 | 462 | 0.98:1 |
ListWith60ListItems.default | 494 | 504 | 0.98:1 |
AvatarMinimalPerf.default | 159 | 164 | 0.97:1 |
FormMinimalPerf.default | 325 | 334 | 0.97:1 |
HeaderSlotsPerf.default | 668 | 688 | 0.97:1 |
IconMinimalPerf.default | 559 | 574 | 0.97:1 |
TextAreaMinimalPerf.default | 404 | 415 | 0.97:1 |
TreeWith60ListItems.default | 127 | 133 | 0.95:1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 711 | 720 | 5000 | |
Breadcrumb | mount | 2464 | 2390 | 1000 | |
Checkbox | mount | 2139 | 2005 | 5000 | |
CheckboxBase | mount | 1788 | 1746 | 5000 | |
ChoiceGroup | mount | 3696 | 3639 | 5000 | |
ComboBox | mount | 744 | 803 | 1000 | |
CommandBar | mount | 8823 | 8859 | 1000 | |
ContextualMenu | mount | 10470 | 9658 | 1000 | |
DefaultButton | mount | 968 | 906 | 5000 | |
DetailsRow | mount | 3002 | 3224 | 5000 | |
DetailsRowFast | mount | 2986 | 2950 | 5000 | |
DetailsRowNoStyles | mount | 2786 | 2780 | 5000 | |
Dialog | mount | 2499 | 2520 | 1000 | |
DocumentCardTitle | mount | 150 | 133 | 1000 | |
Dropdown | mount | 2781 | 2526 | 5000 | |
FocusTrapZone | mount | 1482 | 1452 | 5000 | |
FocusZone | mount | 1475 | 1538 | 5000 | |
IconButton | mount | 1401 | 1401 | 5000 | |
Label | mount | 293 | 264 | 5000 | |
Layer | mount | 3614 | 3533 | 5000 | |
Link | mount | 388 | 358 | 5000 | |
MenuButton | mount | 1137 | 1193 | 5000 | |
MessageBar | mount | 1758 | 1744 | 5000 | |
Nav | mount | 2627 | 2921 | 1000 | |
OverflowSet | mount | 879 | 851 | 5000 | |
Panel | mount | 1997 | 1915 | 1000 | |
Persona | mount | 794 | 819 | 1000 | |
Pivot | mount | 1113 | 1228 | 1000 | |
PrimaryButton | mount | 999 | 984 | 5000 | |
Rating | mount | 6094 | 6204 | 5000 | |
SearchBox | mount | 1004 | 984 | 5000 | |
Shimmer | mount | 2296 | 2354 | 5000 | |
Slider | mount | 1545 | 1545 | 5000 | |
SpinButton | mount | 4004 | 3942 | 5000 | |
Spinner | mount | 326 | 314 | 5000 | |
SplitButton | mount | 2388 | 2460 | 5000 | |
Stack | mount | 427 | 386 | 5000 | |
StackWithIntrinsicChildren | mount | 1732 | 1923 | 5000 | |
StackWithTextChildren | mount | 4109 | 4021 | 5000 | |
SwatchColorPicker | mount | 9437 | 9530 | 5000 | |
TagPicker | mount | 2210 | 2042 | 5000 | |
TeachingBubble | mount | 85331 | 84589 | 5000 | |
Text | mount | 362 | 358 | 5000 | |
TextField | mount | 1170 | 1030 | 5000 | |
ThemeProvider | mount | 1038 | 1108 | 5000 | |
ThemeProvider | virtual-rerender | 587 | 554 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1617 | 1609 | 5000 | |
Toggle | mount | 689 | 632 | 5000 | |
buttonNative | mount | 103 | 119 | 5000 |
@Hotell any way you can get eyes on this small change? Fix just needed to be cherry-picked into stable and I've confirmed this resolves the issue. Since the person reporting is using the CDN, we have to push a fresh PR referencing the latest packages in order to automatically deploy another version. Thanks! |
Related Issue(s)
Fixes #24561
Fixes #