Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: lage ignore globs don't work on info command if untracked files are present #26147

Closed
2 tasks done
Tracked by #30267
Hotell opened this issue Jan 3, 2023 · 20 comments · Fixed by #31949
Closed
2 tasks done
Tracked by #30267

[Bug]: lage ignore globs don't work on info command if untracked files are present #26147

Hotell opened this issue Jan 3, 2023 · 20 comments · Fixed by #31949
Labels

Comments

@Hotell
Copy link
Contributor

Hotell commented Jan 3, 2023

Library

all

Are you reporting Accessibility issue?

no

Reproduction

we have defined ignore globs within lage.config.js

  1. change anything in file matching one of those globs, lets say add comment to .github/CODEOWNERS
  2. create untracked file in repo root -> touch foo.txt
  3. stage codeowners change: git add .github/CODEOWNERS. (dont stage untracked foo.txt ! )
  4. run yarn lage info --since master
  5. this will output all monorepo packages 🚨🚨🚨

Bug Description

Actual Behavior

ignore doesn't work properly if there are untracked files present in repo root

Expected Behavior

ignore works as expected if untracked files are present. if there are no candidates IMO returning all workspace packages as affected is wrong/confusing.

Why is this happening

lage uses workspace-tools under the hood which has hardcoded true flag to return all packages if no candidate package is being returned. This bug was introduced in this PR https://github.com/microsoft/workspace-tools/pull/105/files#diff-45e9ef10fc7a91e55ef79733fe0ebb8939b7b913f7624e43ff250f913596964fR74

Requested priority

Normal

Products/sites affected

whole monorepo

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@Hotell Hotell changed the title [Bug]: lage ignore globs don't work [Bug]: lage ignore globs don't work on info command Jan 3, 2023
@Hotell Hotell changed the title [Bug]: lage ignore globs don't work on info command [Bug]: lage ignore globs don't work on info command if untracked files are present Jan 3, 2023
@Hotell Hotell added Area: DevExp and removed CI labels Jan 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Aug 25, 2023
@microsoft-github-policy-service

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service

This comment was marked as duplicate.

10 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

2 similar comments
@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

@microsoft-github-policy-service

This comment was marked as duplicate.

1 similar comment
@microsoft-github-policy-service

This comment was marked as duplicate.

@Hotell Hotell reopened this Sep 19, 2023

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@Hotell Hotell reopened this Mar 28, 2024
@Hotell
Copy link
Contributor Author

Hotell commented Mar 28, 2024

can be closed after #30267 as not relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants