-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: lage ignore globs don't work on info
command if untracked files are present
#26147
Comments
info
command
info
commandinfo
command if untracked files are present
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
This comment was marked as duplicate.
This comment was marked as duplicate.
10 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
2 similar comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons. Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent. |
can be closed after #30267 as not relevant |
Library
all
Are you reporting Accessibility issue?
no
Reproduction
we have defined
ignore
globs withinlage.config.js
.github/CODEOWNERS
touch foo.txt
git add .github/CODEOWNERS
. (dont stage untracked foo.txt ! )yarn lage info --since master
Bug Description
Actual Behavior
ignore
doesn't work properly if there are untracked files present in repo rootExpected Behavior
ignore
works as expected if untracked files are present. if there are no candidates IMO returning all workspace packages as affected is wrong/confusing.Why is this happening
lage uses
workspace-tools
under the hood which has hardcodedtrue
flag to return all packages if no candidate package is being returned. This bug was introduced in this PR https://github.com/microsoft/workspace-tools/pull/105/files#diff-45e9ef10fc7a91e55ef79733fe0ebb8939b7b913f7624e43ff250f913596964fR74Requested priority
Normal
Products/sites affected
whole monorepo
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: