Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected #27364

Merged
merged 2 commits into from
Apr 3, 2023
Merged

feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected #27364

merged 2 commits into from
Apr 3, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Mar 29, 2023 •
edited
Loading

Previous Behavior

New Behavior

  • check:affected-packages is refactored in 2 ways:
    • npm script alias changed to check:affected
    • --pr flag was removed (it is not used anywhere)
    • added configurable --base argument
    • will notify user about false positives (lage issue)
      • image

Usage:

yarn check:affected

> Set(2) {  '@fluentui/perf-test',  '@fluentui/perf-test-react-components' }

yarn check:affected --package @fluentui/react-text

> false

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 29, 2023
@Hotell Hotell changed the title Hotell/build/executors/improve affected feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected Mar 29, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7c0bbf5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 29, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 618bccf669722de1519e1408661be1919d6a078d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 879 890 5000
Button mount 592 586 5000
Field mount 1558 1543 5000
FluentProvider mount 1102 1100 5000
FluentProviderWithTheme mount 301 284 10
FluentProviderWithTheme virtual-rerender 280 270 10
FluentProviderWithTheme virtual-rerender-with-unmount 291 293 10
InfoButton mount 201 218 5000
MakeStyles mount 1393 1404 50000
Persona mount 2121 2040 5000
SpinButton mount 1865 1830 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 88.882 kB
26.551 kB
react-alert
Alert		 96.647 kB
23.133 kB
react-avatar
Avatar		 60.312 kB
15.579 kB
react-avatar
AvatarGroup		 18.178 kB
6.683 kB
react-avatar
AvatarGroupItem		 76.573 kB
20.086 kB
react-badge
Badge		 25.85 kB
7.585 kB
react-badge
CounterBadge		 26.833 kB
7.889 kB
react-badge
PresenceBadge		 34.458 kB
8.693 kB
react-button
Button		 39.749 kB
9.959 kB
react-button
CompoundButton		 46.921 kB
11.428 kB
react-button
MenuButton		 44.437 kB
11.306 kB
react-button
SplitButton		 52.931 kB
12.872 kB
react-button
ToggleButton		 58.121 kB
11.878 kB
react-card
Card - All		 83.489 kB
23.894 kB
react-card
Card		 78.308 kB
22.431 kB
react-card
CardFooter		 9.035 kB
3.799 kB
react-card
CardHeader		 10.959 kB
4.503 kB
react-card
CardPreview		 9.84 kB
4.153 kB
react-checkbox
Checkbox		 36.067 kB
10.856 kB
react-checkbox
CheckboxField		 43.019 kB
12.787 kB
react-combobox
Combobox (including child components)		 88.73 kB
28.105 kB
react-combobox
ComboboxField		 85.147 kB
27.871 kB
react-combobox
Dropdown (including child components)		 87.428 kB
27.853 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.4 kB
57.516 kB
react-components
react-components: FluentProvider & webLightTheme		 38.819 kB
12.351 kB
react-datepicker-compat
DatePicker Compat		 250.208 kB
66.95 kB
react-dialog
Dialog (including children components)		 93.388 kB
27.408 kB
react-divider
Divider		 19.863 kB
6.697 kB
react-field
Field		 20.552 kB
7.092 kB
react-image
Image		 14.011 kB
4.993 kB
react-infobutton
InfoButton		 130.577 kB
39.439 kB
react-infobutton
InfoLabel		 133.874 kB
40.488 kB
react-input
Input		 25.747 kB
7.697 kB
react-input
InputField		 35.723 kB
10.637 kB
react-label
Label		 12.57 kB
4.586 kB
react-link
Link		 12.301 kB
5.07 kB
react-menu
Menu (including children components)		 130.926 kB
39.629 kB
react-menu
Menu (including selectable components)		 134.062 kB
40.161 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 67.338 kB
17.524 kB
react-popover
Popover		 117.58 kB
35.828 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 15.961 kB
5.675 kB
react-progress
ProgressField		 26.435 kB
8.859 kB
react-provider
FluentProvider		 20.766 kB
7.119 kB
react-radio
Radio		 35.48 kB
11.126 kB
react-radio
RadioGroup		 17.988 kB
6.544 kB
react-radio
RadioGroupField		 28.166 kB
9.735 kB
react-select
Select		 26.957 kB
8.766 kB
react-select
SelectField		 36.293 kB
11.316 kB
react-slider
Slider		 35.919 kB
11.059 kB
react-slider
SliderField		 45.847 kB
14.005 kB
react-spinbutton
SpinButton		 35.648 kB
10.348 kB
react-spinbutton
SpinButtonField		 44.671 kB
12.812 kB
react-spinner
Spinner		 23.425 kB
7.195 kB
react-switch
Switch		 31.413 kB
9.294 kB
react-switch
SwitchField		 38.317 kB
11.21 kB
react-table
DataGrid		 149.878 kB
40.662 kB
react-table
Table (Primitives only)		 47.119 kB
12.703 kB
react-table
Table as DataGrid		 138.018 kB
35.282 kB
react-table
Table (Selection only)		 85.849 kB
21.303 kB
react-table
Table (Sort only)		 85.179 kB
21.113 kB
react-text
Text - Default		 15.018 kB
5.327 kB
react-text
Text - Wrappers		 15.572 kB
5.23 kB
react-textarea
Textarea		 29.07 kB
9.081 kB
react-textarea
TextareaField		 39.454 kB
12.055 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 49.388 kB
16.815 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 618bccf669722de1519e1408661be1919d6a078d

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 144 133 1.08:1
TreeWith60ListItems.default 112 106 1.06:1
ButtonMinimalPerf.default 110 105 1.05:1
PortalMinimalPerf.default 113 108 1.05:1
TableMinimalPerf.default 325 309 1.05:1
AnimationMinimalPerf.default 410 393 1.04:1
BoxMinimalPerf.default 262 253 1.04:1
DividerMinimalPerf.default 280 269 1.04:1
FormMinimalPerf.default 293 281 1.04:1
HeaderMinimalPerf.default 281 270 1.04:1
ChatDuplicateMessagesPerf.default 188 183 1.03:1
ChatWithPopoverPerf.default 245 237 1.03:1
MenuMinimalPerf.default 628 607 1.03:1
TextAreaMinimalPerf.default 358 347 1.03:1
DialogMinimalPerf.default 586 576 1.02:1
EmbedMinimalPerf.default 2021 1989 1.02:1
ListMinimalPerf.default 396 389 1.02:1
ListNestedPerf.default 402 396 1.02:1
ProviderMergeThemesPerf.default 754 739 1.02:1
SliderMinimalPerf.default 837 823 1.02:1
StatusMinimalPerf.default 535 524 1.02:1
AttachmentSlotsPerf.default 776 770 1.01:1
ButtonOverridesMissPerf.default 759 755 1.01:1
CarouselMinimalPerf.default 313 311 1.01:1
LabelMinimalPerf.default 292 288 1.01:1
MenuButtonMinimalPerf.default 1154 1139 1.01:1
ProviderMinimalPerf.default 253 250 1.01:1
RefMinimalPerf.default 150 149 1.01:1
SegmentMinimalPerf.default 262 259 1.01:1
CustomToolbarPrototype.default 1783 1773 1.01:1
ToolbarMinimalPerf.default 673 666 1.01:1
TreeMinimalPerf.default 578 574 1.01:1
ChatMinimalPerf.default 533 533 1:1
CheckboxMinimalPerf.default 1298 1299 1:1
DropdownMinimalPerf.default 1730 1726 1:1
HeaderSlotsPerf.default 594 592 1:1
ImageMinimalPerf.default 301 302 1:1
InputMinimalPerf.default 634 636 1:1
RadioGroupMinimalPerf.default 330 330 1:1
SplitButtonMinimalPerf.default 2629 2616 1:1
TableManyItemsPerf.default 1386 1382 1:1
TooltipMinimalPerf.default 1556 1558 1:1
DatepickerMinimalPerf.default 4178 4221 0.99:1
DropdownManyItemsPerf.default 463 467 0.99:1
FlexMinimalPerf.default 210 213 0.99:1
GridMinimalPerf.default 249 251 0.99:1
ItemLayoutMinimalPerf.default 828 839 0.99:1
ListCommonPerf.default 474 481 0.99:1
RosterPerf.default 1708 1728 0.99:1
PopupMinimalPerf.default 462 467 0.99:1
ReactionMinimalPerf.default 277 279 0.99:1
CardMinimalPerf.default 393 402 0.98:1
LayoutMinimalPerf.default 267 272 0.98:1
ListWith60ListItems.default 431 440 0.98:1
LoaderMinimalPerf.default 226 230 0.98:1
SkeletonMinimalPerf.default 263 269 0.98:1
IconMinimalPerf.default 474 484 0.98:1
TextMinimalPerf.default 251 256 0.98:1
ButtonSlotsPerf.default 355 365 0.97:1
VideoMinimalPerf.default 528 544 0.97:1
AlertMinimalPerf.default 189 198 0.95:1
AccordionMinimalPerf.default 104 111 0.94:1
AttachmentMinimalPerf.default 92 105 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 29, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 982 972 5000
Breadcrumb mount 2378 2415 1000
Checkbox mount 2246 2245 5000
CheckboxBase mount 1970 2001 5000
ChoiceGroup mount 3838 3854 5000
ComboBox mount 1039 1059 1000
CommandBar mount 8470 8437 1000
ContextualMenu mount 19030 18769 1000
DefaultButton mount 1145 1158 5000
DetailsRow mount 3111 3047 5000
DetailsRowFast mount 3066 3062 5000
DetailsRowNoStyles mount 2836 2845 5000
Dialog mount 3415 3412 1000
DocumentCardTitle mount 446 443 1000
Dropdown mount 2728 2741 5000
FocusTrapZone mount 1650 1623 5000
FocusZone mount 1556 1589 5000
GroupedList mount 50419 58719 2
GroupedList virtual-rerender 22162 24477 2
GroupedList virtual-rerender-with-unmount 76567 77301 2
GroupedListV2 mount 446 445 2
GroupedListV2 virtual-rerender 430 433 2
GroupedListV2 virtual-rerender-with-unmount 462 445 2
IconButton mount 1597 1611 5000
Label mount 573 573 5000
Layer mount 3790 3687 5000
Link mount 668 668 5000
MenuButton mount 1406 1412 5000
MessageBar mount 27975 27760 5000
Nav mount 2718 2721 1000
OverflowSet mount 1135 1131 5000
Panel mount 2140 2150 1000
Persona mount 1101 1108 1000
Pivot mount 1337 1347 1000
PrimaryButton mount 1253 1283 5000
Rating mount 5815 5826 5000
SearchBox mount 1257 1251 5000
Shimmer mount 2451 2455 5000
Slider mount 1821 1796 5000
SpinButton mount 3900 3936 5000
Spinner mount 633 650 5000
SplitButton mount 2664 2655 5000
Stack mount 676 681 5000
StackWithIntrinsicChildren mount 1266 1261 5000
StackWithTextChildren mount 3372 3398 5000
SwatchColorPicker mount 8327 8337 5000
TagPicker mount 2151 2150 5000
Text mount 640 643 5000
TextField mount 1339 1341 5000
ThemeProvider mount 1235 1247 5000
ThemeProvider virtual-rerender 922 900 5000
ThemeProvider virtual-rerender-with-unmount 1822 1821 5000
Toggle mount 918 911 5000
buttonNative mount 415 403 5000

@Hotell Hotell marked this pull request as ready for review March 29, 2023 12:30
@Hotell Hotell requested a review from a team as a code owner March 29, 2023 12:30
@Hotell Hotell force-pushed the hotell/build/executors/improve-affected branch from d3a4ade to cda106a Compare March 29, 2023 13:35
@tudorpopams tudorpopams self-requested a review March 30, 2023 12:11
@Hotell Hotell force-pushed the hotell/build/executors/improve-affected branch from cda106a to 7c0bbf5 Compare April 3, 2023 08:43
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@Hotell Hotell merged commit 2bea5b2 into microsoft:master Apr 3, 2023
@Hotell Hotell deleted the hotell/build/executors/improve-affected branch April 3, 2023 09:30
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 4, 2023
@marcosmoura
Merge branch 'master' into marcosmoura/feat/drawer-component
eb96d10 
* master: (39 commits)
  Added merge tests for custom styles (microsoft#27086)
  fix: make Option's checkIcon slot render conditionally (microsoft#27409)
  docs: add subcomponents to Combobox and Dropdown docs (microsoft#27410)
  Breadcrumb spec (microsoft#26742)
  bugfix(react-utilities): increments SlotRenderFunction signature to include children (microsoft#27377)
  fix: Menu should not steal focus on close (microsoft#27414)
  Fixed Overflow component when there's more then one children element (microsoft#27402)
  feat(scripts-executors): support custom base and printing all affected packages for checkIfPackagesAffected (microsoft#27364)
  applying package updates
  feat(scripts-tasks): make perf test setup generic (microsoft#26920)
  fix: ColorPicker preview color updated to ignore forced colors (microsoft#27394)
  fix: Fix babel build error on windows (microsoft#27406)
  chore(react-datepicker-compat): Add vr-tests and bundle-size fixtures for DatePicker (microsoft#27351)
  fix(react-dialog): DialogContent scrollbar always visible (microsoft#27367)
  docs: Add tokens search (microsoft#27265)
  chore(scripts-tasks): remove not needed api-extractor task logs (microsoft#27094)
  chore(react-tree): adds e2e flat tree tests (microsoft#27318)
  applying package updates
  Accessibility fix for empty vertical bar chart (microsoft#26254)
  fix(react-datepicker-compat): Fix theming issues with all themes and WHCM (microsoft#27361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System CI
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @tudorpopams @GeoffCoxMSFT