Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: unable to copy to clipboard content within storybook doc blocks #29265

Closed
2 tasks done
spmonahan opened this issue Sep 22, 2023 · 12 comments
Closed
2 tasks done

[Bug]: unable to copy to clipboard content within storybook doc blocks #29265

spmonahan opened this issue Sep 22, 2023 · 12 comments
Assignees
Labels

Comments

@spmonahan
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

n/a

Are you reporting Accessibility issue?

no

Reproduction

https://react.fluentui.dev/?path=/docs/components-textarea--default

Bug Description

Actual Behavior

  1. Type some text into a Fluent Textarea
  2. Copy the text
  3. Paste the text
  4. Whatever was previously in your clipboard is pasted

Expected Behavior

I should be able to copy text from a Textarea.

textarea_copy_paste.mp4

Browsers

  • Firefox 117.0.1 (64-bit) Windows 11
  • Edge 117.0.2045.36 (Official build) (64-bit) Windows 11

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@ganitx
Copy link

ganitx commented Sep 25, 2023

I couldn't replicate this issue in Edge Version 117.0.2045.41 (Official build) (64-bit) Windows 10, Firefox Windows 10, and Chrome. Copy and paste works by selecting and using keyboard shortcuts in windows 10.

@Hotell
Copy link
Contributor

Hotell commented Sep 27, 2023

this is also happening for Field https://react.fluentui.dev/?path=/docs/components-field--default within storybook docs. outside storybook everything works as expected so this must be some very weird storybook clipboard hijacking.

note: also present on web-components v3 docsite https://web-components.fluentui.dev/?path=/docs/components-textinput--text-input

when you press cmd/ctrl+c there is this storybook popup shown "copied"

image

this seems to be fixed in storybook 7 ( carbon is on v7 https://react.carbondesignsystem.com/?path=/docs/components-textarea--overview )

@Hotell
Copy link
Contributor

Hotell commented Sep 27, 2023

confirmed this is SB bug and they have no plans to fix it for v6 unfortunately storybookjs/storybook#18611 (comment)

@Hotell
Copy link
Contributor

Hotell commented Sep 27, 2023

@behowell ran into similar thing some time ago #24135.

With v6 only workaround is to stopping rendering show code functionality - which for these more complex control is not something we should do. thoughts ?

@Hotell Hotell added dependencies Pull requests that update a dependency file Storybook Type: Bug 🐛 Area: Build System and removed Needs: Triage 🔍 labels Sep 27, 2023
@Hotell Hotell changed the title [Bug]: Cannot copy text from Textarea [Bug]: unable to copy content within storybook doc blocks Sep 27, 2023
@Hotell Hotell changed the title [Bug]: unable to copy content within storybook doc blocks [Bug]: unable to copy to clipboard content within storybook doc blocks Sep 27, 2023
@Hotell Hotell added Area: Documentation and removed Component: Textarea Textarea component. labels Sep 27, 2023
@spmonahan
Copy link
Contributor Author

Perhaps we should upgrade to v7? @TristanWatanabe upgraded another repo to v7 so he can probably comment on the effort required.

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Mar 25, 2024

Because this reported issue has not had any activity for over 180 days, we're automatically closing it for house-keeping reasons.

Still require assistance? Please, create a new issue with up-to date details and latest version of Fluent.

@dmytrokirpa dmytrokirpa self-assigned this Jul 10, 2024
@mltejera mltejera reopened this Jul 18, 2024
@mltejera
Copy link
Contributor

Hey is there an ETA on the v7 upgrade? This bug is making some of the theme tooling on our site unusable... like, if it were a product this would be a sev 0, work through the weekend, we're breaking SLA and losing money bug.

@EdDaWord
Copy link
Contributor

+1 to Mason's point. In cases like createV9Theme

There's no way to actually copy the output, even inspecting the HTML only gets you 80% of the output. It'd be amazing if we could upgrade to v7.

image

@Hotell
Copy link
Contributor

Hotell commented Jul 19, 2024

like, if it were a product this would be a sev 0, work through the weekend, we're breaking SLA and losing money bug.

thanks for your input. as you can see this has been opened almost a year ago with no complaint besides internal core team.

Hey is there an ETA on the v7 upgrade? This bug is making some of the theme tooling on our site unusable... like, if it were a product this would be a sev 0, work through the weekend, we're breaking SLA and losing money bug.

it's planned for this Quarter - you can check all planned work within our Unified Project Board

@robertpenner
Copy link
Collaborator

This copy hijacking was affecting my work as well.

@Hotell
Copy link
Contributor

Hotell commented Aug 8, 2024

closing #30858

@Hotell Hotell closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants