Fix issue preventing copying text out of theme storybook documentation #24135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bc1db9:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 50b08528ea6ed19e13f002276fb880271771e425 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1264 | 1201 | 5000 | |
| Button | mount | 813 | 798 | 5000 | |
| FluentProvider | mount | 1495 | 1417 | 5000 | |
| FluentProviderWithTheme | mount | 623 | 619 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 521 | 515 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 545 | 559 | 10 | |
| MakeStyles | mount | 1673 | 1737 | 50000 | |
| SpinButton | mount | 2522 | 2415 | 5000 |
khmakoto
approved these changes
Jul 28, 2022
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "Fix issue preventing copying text out of theme storybook documentation", | |||
There was a problem hiding this comment.
Suggested change
| "comment": "Fix issue preventing copying text out of theme storybook documentation", | |
| "comment": "fix: Fix issue preventing copying text out of theme storybook documentation.", |
There was a problem hiding this comment.
Ok, I fix fixed the description 👍
ling1726
approved these changes
Jul 29, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
It is not possible to copy text out of theme documentation on these pages:
The root cause is a bug in storybook:
New Behavior
A workaround for the storybook bug is to turn off the "Show code" buttons for these stories:
In this case, there is nothing interesting in the code (it just shows a wrapper component like
<Colors />), so there's no harm in removing it for the theme documentation. In fact, for that reason it's probably clearer to not have the "Show code" button, so this change should remain even after the underlying storybook issue is fixed.Related Issue(s)